Merged
Conversation
… parent watch to the constructor
… using the 3-arg constructor with a `null` arg)
…WatchEvent` (because having it outside didn't lead to significantly simpler code overall)
…erflow-support/richer-active-watch
…t/scaffolding Improved overflow support: Scaffolding
…support/richer-active-watch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=========================================
+ Coverage 80.0% 80.7% +0.7%
- Complexity 88 131 +43
=========================================
Files 11 16 +5
Lines 415 567 +152
Branches 41 64 +23
=========================================
+ Hits 332 458 +126
- Misses 57 69 +12
- Partials 26 40 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…roved-overflow-support/event-handlers-with-active-watch
…t/richer-active-watch Improved overflow support: Internal `EventHandlingWatch` interface
…support/event-handlers-with-active-watch
…t/event-handlers-with-active-watch Improved overflow support: Internal event handlers can dispatch new events
…t/fix-delete-detection-in-indexing-rescanner Improved overflow support: Fix detection of `DELETED` events in `IndexingRescanner`
…support/jdk-file-tree-watch
…t/jdk-file-tree-watch Improved overflow support: Recursive directory watches
DavyLandman
approved these changes
Mar 28, 2025
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
Yes, looks good, 2 small comments
… generated for files that exist
…t-modified-times only when the files involved truly exist
…prove performance of `IndexingRescanner`
https://github.com/SWAT-engineering/java-watch into improved-overflow-support/parameterized-torture-tests
…t/parameterized-torture-tests Improved overflow support: Parameterized torture tests
…t/update-readme Improved overflow support: Update README
This was referenced Apr 8, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This is the main PR to address #12. It consists of the following auxiliary PRs:
EventHandlingWatchinterface #19DELETEDevents inIndexingRescanner#28Tasks
Features:
Make it possible to distinguish original events from synthetic events (comment)?-- Not needed for nowCode quality:
Reduce visibility of(moved to a separate issue: Reduce visibility ofJDK...JDK...classes #22)MemorylessRescannervsIndexingRescanner(comment 1, comment 2)Take more advantage of filtering capability (e.g., conceptually,(moved to separate issue: Use filter in the implementation ofJDKFileWatchis just aJDKDirectoryWatchwith a particular filter)JDKFileWatch#31)Performance:
IndexingRescannermore hierarchical to improve performance (time and space) (comment)Debounce overflow handling (comment)(moved to separate issue: Debounce overflow handler #32)