Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Commit 4acea41

Browse files
damianhdamianh
committed
Missing a few ConfigureAwait(false)s
1 parent dea32f2 commit 4acea41

4 files changed

Lines changed: 45 additions & 4 deletions

File tree

‎src/SqlStreamStore.AcceptanceTests/SqlStreamStoreAcceptanceTests.Subscriptions.cs‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -960,6 +960,46 @@ public async Task When_dispose_store_then_should_dispose_all_stream_subscription
960960
}
961961
}
962962

963+
[Fact, Trait("Category", "Subscriptions")]
964+
public async Task When_subscribe_to_stream_and_append_messages_then_should_receive_message()
965+
{
966+
using (var fixture = GetFixture())
967+
{
968+
using (var store = await fixture.GetStreamStore())
969+
{
970+
string streamId1 = "stream-1";
971+
string streamId2 = "stream-2";
972+
var received = new AsyncAutoResetEvent();
973+
string streamIdReceived = null;
974+
using (store.SubscribeToStream(
975+
streamId1,
976+
null,
977+
(_, message, ct) =>
978+
{
979+
streamIdReceived = message.StreamId;
980+
received.Set();
981+
return Task.CompletedTask;
982+
}))
983+
{
984+
await AppendMessages(store, streamId1, 1);
985+
await AppendMessages(store, streamId2, 1);
986+
await received.WaitAsync().WithTimeout();
987+
streamIdReceived.ShouldBe(streamId1);
988+
989+
await AppendMessages(store, streamId1, 1);
990+
await AppendMessages(store, streamId2, 1);
991+
await received.WaitAsync().WithTimeout();
992+
streamIdReceived.ShouldBe(streamId1);
993+
994+
await AppendMessages(store, streamId1, 1);
995+
await AppendMessages(store, streamId2, 1);
996+
await received.WaitAsync().WithTimeout();
997+
streamIdReceived.ShouldBe(streamId1);
998+
}
999+
}
1000+
}
1001+
}
1002+
9631003
private static async Task AppendMessages(IStreamStore streamStore, string streamId, int numberOfEvents)
9641004
{
9651005
for(int i = 0; i < numberOfEvents; i++)

‎src/SqlStreamStore.MsSql.Tests/MsSqlStreamStoreFixture.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ namespace SqlStreamStore
77
#endif
88
using System.Linq;
99
using System.Threading.Tasks;
10+
using SqlStreamStore.Infrastructure;
1011

1112
public class MsSqlStreamStoreFixture : StreamStoreAcceptanceTestFixture
1213
{
@@ -98,7 +99,7 @@ private async Task CreateDatabase()
9899
{
99100
using(var connection = _localInstance.CreateConnection())
100101
{
101-
await connection.OpenAsync();
102+
await connection.OpenAsync().NotOnCapturedContext();
102103
var tempPath = Environment.GetEnvironmentVariable("Temp");
103104
var createDatabase = $"CREATE DATABASE [{_databaseName}] on (name='{_databaseName}', "
104105
+ $"filename='{tempPath}\\{_databaseName}.mdf')";

‎src/SqlStreamStore.MsSql/MsSqlStreamStore.StreamMetadata.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ protected override async Task<SetStreamMetadataResult> SetStreamMetadataInternal
5656
MsSqlAppendResult result;
5757
using(var connection = _createConnection())
5858
{
59-
await connection.OpenAsync(cancellationToken);
59+
await connection.OpenAsync(cancellationToken).NotOnCapturedContext();
6060

6161
using(var transaction = connection.BeginTransaction())
6262
{

‎src/SqlStreamStore.MsSql/MsSqlStreamStore.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public async Task<CheckSchemaResult> CheckSchema(
150150

151151
using(var connection = _createConnection())
152152
{
153-
await connection.OpenAsync(cancellationToken);
153+
await connection.OpenAsync(cancellationToken).NotOnCapturedContext();
154154

155155
using (var command = new SqlCommand(_scripts.GetSchemaVersion, connection))
156156
{
@@ -253,7 +253,7 @@ protected override async Task<long> ReadHeadPositionInternal(CancellationToken c
253253

254254
using(var connection = _createConnection())
255255
{
256-
await connection.OpenAsync(cancellationToken);
256+
await connection.OpenAsync(cancellationToken).NotOnCapturedContext();
257257

258258
using(var command = new SqlCommand(_scripts.ReadHeadPosition, connection))
259259
{

0 commit comments

Comments
 (0)