Adopt sk.ainet.multiplatform + sk.ainet.npm-pins from SKaiNET-build-logic - #5
Merged
Merged
Conversation
…ogic
Replaces every module's hand-rolled plugins{}/kotlin{ android{...};
jvm(); androidNativeArm32(); ...; js{browser()}/wasmJs{browser()} }
boilerplate (copy-pasted 6 times, one line different per module) with
id("sk.ainet.multiplatform") + a per-module skainet { namespace = ... }
block and a gradle.properties skainet.targets declaration (must be a
Gradle property, not part of the skainet{} DSL -- Kotlin targets have to
exist before the module's own kotlin{} block runs, see SkainetTargets'
own doc comment).
Supersedes #3 (the earlier manual linuxX64 fix): the "linux" target
group expands to linuxX64+linuxArm64 together, so this exact class of
bug -- one target silently missing from a hand-copied list -- is now
structurally impossible instead of caught after the fact.
sk.ainet.npm-pins applied at root (real application, not apply false):
every module here builds js and/or wasmJs targets, and
sk.ainet.multiplatform refuses to configure a web target unless it's in
force at the root. No pins declared yet (nothing to pin currently) --
this just puts the mechanism in place for when one's needed.
Both plugin versions pinned once via pluginManagement.plugins{} in
settings.gradle.kts rather than at each application site: they share an
implementation jar, and Gradle can't cleanly resolve more than one
plugin ID from the same jar with an explicit version at each individual
site ("plugin is already on the classpath with an unknown version").
kotlin-test in commonTest is now automatic (skainet {
kotlinTestInCommonTest } defaults true) -- the explicit
implementation(libs.kotlin.test) lines every module had are gone,
nothing else changed about test dependencies.
Verified: full multi-project configuration green; ./gradlew
publishToMavenLocal (728 tasks, all 6 modules x every target) green;
the repo's own validate-published-poms.sh gate passes clean on all 70
published POMs (group/version resolution for internal project()
dependencies unchanged); jvmTest + linuxX64Test green.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins{}/kotlin{ android{...}; jvm(); ...; js{browser()}/wasmJs{browser()} }boilerplate (copy-pasted 6 times) withid("sk.ainet.multiplatform")+ a per-moduleskainet { namespace = ... }block, consuming the real Maven Central release of SKaiNET-build-logic 1.0.0.linuxX64fix): thelinuxtarget group expands tolinuxX64+linuxArm64together, so this exact class of bug is now structurally impossible instead of caught after the fact. Closing Add linuxX64 target to all six modules #3 once this merges.sk.ainet.npm-pinsapplied for real at root (every module here builds js/wasmJs, andsk.ainet.multiplatformrequires it in force at the root) -- no pins declared yet, just puts the mechanism in place.kotlin-testincommonTestis now automatic (ask.ainet.multiplatformdefault), so the explicitimplementation(libs.kotlin.test)line every module had is gone.linuxX64bug) becomes impossible by construction rather than something to notice and fix per-module.Test plan
./gradlew tasks)./gradlew publishToMavenLocalgreen -- 728 tasks, all 6 modules x every target (jvm/android/androidNative/ios/macos/linux/js/wasmJs)validate-published-poms.shgate passes clean on all 70 published POMs -- group/version resolution for internalproject()dependencies (audio-mel→audio-core,audio-source→audio-wav) unchangedjvmTest+linuxX64Testgreen across all modules🤖 Generated with Claude Code