Add linuxX64 target to all six modules - #3
Closed
michalharakal wants to merge 1 commit into
Closed
michalharakal wants to merge 1 commit into
michalharakal wants to merge 1 commit into
Conversation
Every module's kotlin {} block declares jvm/iosArm64/macosArm64/linuxArm64
(plus js/wasmJs/androidNative on some) but never linuxX64 -- the dev/CI
runner architecture for the downstream ASR cartridge repos that want to
adopt this library (asr-whisper-iree-cartridge, asr-moonshine-iree-cartridge,
asr-vad-silero-iree-cartridge, all under dtag-cartrdige-forge), all of which
target linuxX64 explicitly. Without this, adopting SKaiNET-audio in place
of their own duplicated WAV I/O and mel-spectrogram code would silently
drop linuxX64 support.
Verified: ./gradlew linuxX64Test green across all six modules. (The
pre-existing wasmJsBrowserTest failure -- missing headless Chrome -- is
unrelated: reproduces identically on unmodified develop.)
Fixes #2
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012BmAYE4tZ7HsULEW8todNP
4 tasks
Contributor
Author
|
Superseded by #5, which adopts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audio-core,audio-wav,audio-mel,audio-vad,audio-stream,audio-source) published alinuxX64variant -- each declaredjvm()/iosArm64()/macosArm64()/linuxArm64()(plusjs/wasmJs/Android-native on some) but neverlinuxX64().linuxArm64()declaration -- no source changes, no target-specific code needed since nothing in these modules is platform-coupled beyond the existingexpect/actualsplit (audio-source'sMicAudioSourcestays Android-only,WavAudioSourcestays JVM-only).dtag-cartrdige-forge(asr-whisper-iree-cartridge,asr-moonshine-iree-cartridge,asr-vad-silero-iree-cartridge) adopting this library in place of their own duplicated WAV I/O and mel-spectrogram code -- all three targetlinuxX64as their dev/CI runner architecture.Test plan
./gradlew linuxX64Testgreen across all six modulesaudio-wav:wasmJsBrowserTest, missing headless Chrome) is pre-existing and unrelated -- reproduces identically on an unmodifieddevelopclone, nothing to do with this change🤖 Generated with Claude Code
https://claude.ai/code/session_012BmAYE4tZ7HsULEW8todNP