chore: bump sk.ainet.multiplatform/sk.ainet.npm-pins to 1.1.0 - #12
Merged
Merged
Conversation
Picks up the new centralized jvmTarget default (JvmTarget.JVM_17 for the plain jvm() target), previously unset and implicitly following whatever JDK ran the build. No source changes needed; verified via javap that compiled class files now carry major version 61 (Java 17) regardless of host JDK. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012BmAYE4tZ7HsULEW8todNP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sk.ainet.multiplatform/sk.ainet.npm-pinsfrom1.0.0to1.1.0(both pinned once insettings.gradle.kts'spluginManagement.plugins {}, per the plugin-resolution gotcha documented there).jvmTargetdefault from SKaiNET-build-logic 1.1.0 —JvmTarget.JVM_17for the plainjvm()target, previously left unset entirely (implicitly followed whatever JDK ran the build).Test plan
./gradlew jvmTest linuxX64Testgreen locally against the bumped versions.javap -vthataudio-core's compiled JVM class files now carry major version 61 (Java 17), regardless of host JDK (this session's host runs JDK 25).