ci(docs): deploy on push to develop instead of a GitHub Release - #977
Merged
Merged
Conversation
deploy-docs was gated on `github.event_name == 'release'`, matching the stated intent that the canonical site tracks the latest release. But this repo's release process only ever pushes a git tag — no GitHub Release object is ever created (`gh release list` is empty) — so that trigger has never fired once. Confirmed via Actions history: every past docs.yml run was a push or pull_request event, never release. The live site has been frozen since whatever deployed it outside this workflow, missing content that landed on develop long ago (e.g. SKEEP-002/003, reachable from tag 0.40.1). Deploy on every push to develop instead, matching how SKaiNET-transformers' docs.yml already does it. The existing `paths:` filter on the push trigger already scopes this to docs-relevant changes. Fixes #975 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
aharakal
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #975.
deploy-docswas gated ongithub.event_name == 'release', matchingthe docs' stated intent that the canonical site tracks the latest release. But this
repo's release process only ever pushes a git tag (
0.40.1,0.39.1, ...) — noGitHub Release object is ever created (
gh release listreturns empty). Confirmedvia Actions history: every historical
docs.ymlrun was apushorpull_requestevent;
releasehas never fired once. The live site(https://skainet-developers.github.io/SKaiNET/skainet/) has been frozen since
whatever deployed it outside this workflow — missing content that's been on
developfor a while, e.g. SKEEP-002/SKEEP-003 (present innav.adoc/index.adoc,reachable from tag
0.40.1, invisible on the live site).Fix
Deploy on every push to
developinstead — matches howSKaiNET-transformers'docs.ymlalready does it (if: github.ref == 'refs/heads/develop' && github.event_name == 'push'), a pattern that's actuallyproven to fire in that repo's Actions history. The existing
paths:filter on thepushtrigger already scopes rebuilds to docs-relevant changes(
docs/**, the workflow file,build.gradle.kts,build-logic/**,skainet-lang/skainet-lang-core/**), so this doesn't change when the siterebuilds for validation — only makes successful builds on
developactuallypublish.
Dropped the now-dead
release: types: [published]trigger entirely rather thanleaving it wired to nothing, to avoid the same "looks like it does something, does
nothing" confusion that caused this bug in the first place.
Not in scope
Antora docs site has no version selector — pin per release instead of a single unversioned component #976, deliberately independent of this fix (this issue is "the single current
version doesn't deploy at all"; Antora docs site has no version selector — pin per release instead of a single unversioned component #976 is "there's only ever one version to begin
with").
by having the release process create real GitHub Releases) — noted as an
alternative fix option in Docs site never deploys — deploy-docs is gated on a GitHub Release that this repo never creates #975 but not the one taken here; left as a future option
if that framing turns out to matter more than "always current with develop".
Verification
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/docs.yml'))"— valid YAMLbuild-docsjob, Antora build steps, and Dokka bundling untouched🤖 Generated with Claude Code