Remove ExperimentalMemoryApi opt-in gate (SKEEP-003) - #1265
Merged
Merged
Conversation
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
1 similar comment
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
SKEEP-003's M0/M1/M2 milestones all shipped complete in 0.49.0, so the annotation's "may still change until milestone M1 is complete" warning was stale. Delete ExperimentalMemoryApi and strip every @OptIn/ @ExperimentalMemoryApi annotation referencing it (227 files) — the sk.ainet.lang.memory API (Storage, Scope, Format, Layout, TensorView, WeightForm, WeightByteOrder, ...) is now used without opt-in. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PLfVvtURRYZETceamLi8kP
apiCheck failed on develop's CI: the checked-in skainet-lang-core.api snapshot still declared the deleted ExperimentalMemoryApi annotation class. Regenerated via ./gradlew apiDump. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PLfVvtURRYZETceamLi8kP
michalharakal
force-pushed
the
feature/remove-experimental-memory-api
branch
from
September 6, 2026 13:36
a4dc648 to
86b773d
Compare
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExperimentalMemoryApiannotation's "may still change until milestone M1 is complete" warning was stale.ExperimentalMemoryApiand strips every@OptIn(ExperimentalMemoryApi::class)/@ExperimentalMemoryApiannotation referencing it across 227 files.sk.ainet.lang.memoryAPI (Storage,Scope,Format,Layout,TensorView,WeightForm,WeightByteOrder, …) no longer requires opt-in.[Unreleased] / Changed.Test plan
./gradlew compileKotlinJvm compileKotlinMetadata compileTestKotlinJvm— clean, noExperimentalMemoryApiwarnings leftskainet-lang-core./gradlew test -x :skainet-apps:skainet-grayscale-cli:test— green (that module'sHloCompilerTest.testGpuCapabilitiesDetectionfails identically ondevelopbefore this change too — pre-existing CUDA-detection environment issue, unrelated)🤖 Generated with Claude Code
https://claude.ai/code/session_01PLfVvtURRYZETceamLi8kP