SEE: simplify stm variable initialization

pb00067 · vondele · commit f4986f45967c · 2021-07-13T17:31:15.000+02:00
Pull official-stockfish#3458 removed the only usage of pos.see_ge() moving pieces that don't belong to the side to move, so we can simplify this, adding an assert. closes official-stockfish#3607 No functional change
diff --git a/src/position.cpp b/src/position.cpp
@@ -1080,8 +1080,9 @@ bool Position::see_ge(Move m, Value threshold) const {
   if (swap <= 0)
       return true;
 
+  assert(color_of(piece_on(from)) == sideToMove);
   Bitboard occupied = pieces() ^ from ^ to;
-  Color stm = color_of(piece_on(from));
+  Color stm = sideToMove;
   Bitboard attackers = attackers_to(to, occupied);
   Bitboard stmAttackers, bb;
   int res = 1;
