Refactor: modernize cmake, boost, qt, and others to the latest or near latest by basisunus · Pull Request #2463 · SCIInstitute/SCIRun

basisunus · 2026-03-13T20:48:07Z

Built on Windows 10 with Visual Studio 2022.
Runs on Windows.
Some issues with vector out of bound, possibly initialization issues and qt related.

trying to use tetgen as an example to figure out a working solution

added tags for repos in cibc-internal and use tags to download src

# Conflicts: # Superbuild/Cleaver2External.cmake # Superbuild/FreetypeExternal.cmake # Superbuild/GlewExternal.cmake # Superbuild/SQLiteExternal.cmake # Superbuild/ZlibExternal.cmake

…those in scirun cmake next

basisunus · 2026-05-01T17:02:27Z

looks like the windows failures are from a misconfiguration of qwt path for packaging. since it's built as static, there is no need to add it to packaging.

…e link errors of unexported symbols (singlton::instance_) in dlls

dcwhite

Overall it's OK, we'll need to enable testing before it gets merged to master though. I requested several easy clean-up-style changes. I'll try to run this through AI review as well. @basisunus @jessdtate

dcwhite · 2026-05-05T19:15:11Z

@@ -0,0 +1,16 @@
+$BuildDir = "C:\Users\Yong\Documents\SCIRun\build"


Fix hard-coded path, or don't check this in

dcwhite · 2026-05-05T19:15:20Z

+# Safe SCIRun build directory cleanup
+# ============================================================
+
+$ExpectedBuildDir = "C:\Users\Yong\Documents\SCIRun\build"


dcwhite · 2026-05-05T19:16:13Z

 TARGET_LINK_LIBRARIES(Core_CommandLine
-  ${SCI_BOOST_LIBRARY}
+  Boost::filesystem
+  Boost::program_options


I like this because it shows exactly what we're using in Boost and where. Will make replacement easier down the road

dcwhite · 2026-05-05T19:24:35Z


 #include <gtest/gtest.h>

+/// @todo: this won't link in debug mode due to Logging::Instance impl


@basisunus Make a github issue to fix this later

dcwhite · 2026-05-05T19:25:52Z

-	// Remove intermediate python variables
-	PyRun_SimpleString( "del (interpreter, __internal_compiler, __term_io, __term_err)\n" );
-  PRINT_PY_INIT_DEBUG(12);
+  PyRun_SimpleString("del (interpreter, __internal_compiler, __term_io, __term_err)\n");


This whole file is a mess (it was already a mess), it will need heavy testing on all three platforms. I'll make a new issue

dcwhite · 2026-05-05T19:40:58Z

+  # ------------------------------------------------------------
+  IF(IS_DIRECTORY "${Qt_PATH}")
+    if (QT_VERSION_MAJOR STREQUAL "6")
+      FIND_PACKAGE(Qt${QT_VERSION_MAJOR} ${SCIRUN_QT_MIN_VERSION}


Yes, here is an example so you don't litter cmakes with IF 5 ELSE 6 stuff

dcwhite · 2026-05-05T19:41:29Z


 IF(WITH_OSPRAY)
-  ADD_EXTERNAL( ${SUPERBUILD_DIR}/OsprayExternal.cmake Ospray_external )
+  INCLUDE(${SUPERBUILD_DIR}/TBBExternal.cmake)


Revert this section or just comment it out

dcwhite · 2026-05-05T19:41:43Z

@@ -0,0 +1,47 @@
+#  For more information, please see: http://software.sci.utah.edu


dcwhite · 2026-05-05T19:43:24Z

 #  DEALINGS IN THE SOFTWARE.

-SET_PROPERTY(DIRECTORY PROPERTY "EP_BASE" ${ep_base})
+# -------------------------------------------------------


This is an improvement, but still should've been done separately.

dcwhite · 2026-05-05T19:43:47Z

@@ -0,0 +1,4 @@
+
+set(_cfg_dir "C:/Users/Yong/Documents/SCIRun/build/Externals/Install/Tny_external/lib/cmake/Tny")


Hard-coded paths, please fix

dcwhite · 2026-05-06T04:53:31Z

Python crashes on Mac:

Thread 18 Crashed:
0 Python 0x106ff759c _PyErr_SetRaisedException + 0 (errors.c:27) [inlined]
1 Python 0x106ff759c _PyErr_Restore + 0 (errors.c:65) [inlined]
2 Python 0x106ff759c _PyErr_Clear + 0 (errors.c:524) [inlined]
3 Python 0x106ff759c PyErr_Clear + 28 (errors.c:532)
4 libCore_Python.dylib 0x105e572cc SCIRun::Core::PythonInterpreter::run_string(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator> const&) + 76
5 libModules_Python.dylib 0x105935354 SCIRun::Modules::Python::InterfaceWithPython::runTopLevelCode() const + 364
6 libModules_Python.dylib 0x105933c0c SCIRun::Modules::Python::InterfaceWithPython::execute() + 184
7 libDataflow_Network.dylib 0x1060dda68 SCIRun::Dataflow::Networks::Module::executeWithSignals() + 552
8 libInterface_Application.dylib 0x102dcbb00 SCIRun::Gui::ModuleWidget::executeWithSignals() + 112
9 libEngine_Scheduler.dylib 0x103ea6e0c SCIRun::Dataflow::Engine::DynamicExecutor::ModuleExecutor::run() const + 404
10 libEngine_Scheduler.dylib 0x103ea6c30 void* std::__1::__thread_proxy[abi:ne200100]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_deletestd::__1::__thread_struct>, SCIRun::Dataflow::Engine::DynamicExecutor::ExecutionThreadGroup::startExecution(SCIRun::Dataflow::Engine::DynamicExecutor::ModuleExecutor const&)::'lambda'()>>(void*) + 56
11 libsystem_pthread.dylib 0x1952c7bc8 _pthread_start + 136
12 libsystem_pthread.dylib 0x1952c2b80 thread_start + 8

dcwhite · 2026-05-06T04:54:08Z

-  )
-endif()
+TARGET_LINK_LIBRARIES(Interface_Modules_Math
+  Qt::Svg


dcwhite · 2026-05-06T04:55:42Z

To smoke test Python, add an InterfaceWithPython module then type "print(1)" in the code editor. Click Execute, and it should print the number 1 to the console.

…cution

# Conflicts: # src/Core/Python/PythonInterpreter.cc

basisunus · 2026-05-11T21:43:16Z

python runs without crash on mac

dcwhite · 2026-05-14T19:00:35Z

python runs without crash on mac

Confirmed on my Macbook Air M4

basisunus added 30 commits January 14, 2026 16:38

fixing cmake and externals

5288c27

boost builds on windows with vs 2022

d808f56

fixing qt errors

b9358db

fixing boost include dir

8ef9b25

cleaned boost issues

e9dcbbd

fixing python new version

c3e0c04

udpated cmakes for externals

4d7ffbc

issues with externals

18d684c

trying to use tetgen as an example to figure out a working solution

updated tetgen to install

e948db0

removed errors from cleaver2

64ec713

updating external cmakes

f5ef94d

added tags for repos in cibc-internal and use tags to download src

external cmakes

336571d

fixing freetype

056c4d1

making cmake changes

7b788d5

Merge branch 'master' into refactor

92bb6cb

# Conflicts: # Superbuild/Cleaver2External.cmake # Superbuild/FreetypeExternal.cmake # Superbuild/GlewExternal.cmake # Superbuild/SQLiteExternal.cmake # Superbuild/ZlibExternal.cmake

fixing dependency on zlib for external libs

5efaeb8

fixing zlib interdependency

1d869a5

updated teem

0ecda93

fixed teem

cb8a5f2

scirun cmake errors

01b54f0

making sure paths generated in superbuild are correct. need to check …

3ff41f9

…those in scirun cmake next

finding boost in scirun src

103f83b

installing boost headers

6d0402a

fixed glm headers but there are more for boost, glew, tny, lodepng

bac6179

cmake

e432dd0

cmake

1168d71

headers

a013417

header copy

ab20c05

tny header path

41d0e34

default qt path on my computer

65ec892

basisunus added 3 commits May 1, 2026 12:11

disabled tests for core logging similar to applications because of th…

ffc3c79

…e link errors of unexported symbols (singlton::instance_) in dlls

removed qwt from cpack install because it's built static

f4fbadd

division by zero at drawing progress bar

f84b512

basisunus marked this pull request as ready for review May 4, 2026 18:48

scale bar crash

929c657

dcwhite self-requested a review May 5, 2026 19:13

dcwhite assigned basisunus May 5, 2026

dcwhite added Build External Libraries Deployment labels May 5, 2026

dcwhite requested changes May 5, 2026

View reviewed changes

updated based on dan's comments

a844a8e

dcwhite reviewed May 6, 2026

View reviewed changes

basisunus added 12 commits May 6, 2026 15:57

python

e87d416

switched python functions for gil state because of multi threaded exe…

b4a3da3

…cution

removed comments

5ca858c

python

069cc0b

switched python functions for gil state because of multi threaded exe…

2b3a4c5

…cution

removed comments

5acf6c2

added PyEval_SaveThread to python initialization to fix thread state

ed7a3d9

added PyEval_SaveThread to python initialization to fix thread state

8b6459c

guard boost python objects

5285567

guard boost::python::object

4546130

reverted py_finalize

c3334f7

Merge branch 'refactor_update' into refactor

10999e4

# Conflicts: # src/Core/Python/PythonInterpreter.cc

		@@ -0,0 +1,16 @@
		$BuildDir = "C:\Users\Yong\Documents\SCIRun\build"


		#include <gtest/gtest.h>

		/// @todo: this won't link in debug mode due to Logging::Instance impl

		@@ -0,0 +1,47 @@
		# For more information, please see: http://software.sci.utah.edu

		@@ -0,0 +1,4 @@

		set(_cfg_dir "C:/Users/Yong/Documents/SCIRun/build/Externals/Install/Tny_external/lib/cmake/Tny")

Conversation

basisunus commented Mar 13, 2026

Uh oh!

basisunus commented May 1, 2026

Uh oh!

dcwhite left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcwhite commented May 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcwhite commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

basisunus commented May 11, 2026

Uh oh!

dcwhite commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dcwhite commented May 6, 2026 •

edited

Loading