fix for issue where if there were multiple signing certs and no encry…#65
Merged
pitbulk merged 3 commits intoSAML-Toolkits:masterfrom Sep 14, 2017
Merged
fix for issue where if there were multiple signing certs and no encry…#65pitbulk merged 3 commits intoSAML-Toolkits:masterfrom
pitbulk merged 3 commits intoSAML-Toolkits:masterfrom
Conversation
…ption certs, only the first signing cert is returned
Contributor
|
Can you provide test so we assure we don't break in the future? |
Contributor
Author
|
yes, just figuring out the environment. Once the tests pass, I will update the tests. |
Contributor
Author
|
@pitbulk this PR should be ready for you to take a look! |
Contributor
Author
|
Anything else needed here to get this merged and to make a patch release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ption certs, only the first signing cert is returned