Coverage increased (+0.1%) to 95.253% when pulling 59b5748 on macfound:master into 898f95c on onelogin:master.

Nice catch

Released 1.2.1

Let me know if you experience any other issue.

@pitbulk what needs to be done so that the issue that was fixed here is covered by the unit tests?

@jgehrcke

At response_test.py we should create the methods:

• testSignatureWantAssertionsSigned
• testSignatureWantMessagesSigned

Both should have as input 2 valid SAMLResponse One with only assertion signed, other with all message signed, and with strict mode enabled.

testSignatureWantAssertionsSigned:

• With wantAssertionsSigned disabled both responses must be consider valid
• With wantAssertionsSigned enabled only the response with signed assertion must be consider valid

testSignatureWantMessagesSigned:

• With wantMessagesSigned disabled both responses must be consider valid
• With wantMessagesSigned enabled only the response with signed whole messag signed must be consider valid

Do you want to contribute with a PR?