Fix for #480 - eFAST analysis erroring#481
Merged
ConnectedSystems merged 5 commits intoFeb 6, 2022
Merged
Conversation
Generated sample index is 1 step too large under some circumstances
Member
|
Thanks for the quick fix, looks good |
Member
Author
|
In setting up tests to catch any regressions on this I may have stumbled on a deeper bug. I've come up with a solution but I will ask someone more knowledgeable than I to double check my fix. |
Member
Author
|
Inviting @Xifus to provide some thoughts. I have added tests which currently all pass but there may be some edge cases I've missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in title - closes #480