Repository navigation
R23-T057: Fix pydocstyle findings in dilation_operation.py and add strict Ruff review - #67
Open
code-paul-creator wants to merge 1 commit into
Open
code-paul-creator wants to merge 1 commit into
code-paul-creator wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Runs all of Ruff's rules (
--select ALL) ondigital_image_processing/morphological_operations/dilation_operation.py, which already passes the repo config, fixes the findings that match CONTRIBUTING.md, and documents the decision for every other code inwork/R23-T057/REVIEW.md.Related Issue
Fixes: #57
Type of Change
Changes Made
rgb_to_gray,gray_to_binaryanddilationnow end with a period and are followed by a blank line (D205, D400, D415).work/R23-T057/REVIEW.md(every--select ALLcode with a decision) and the raw Ruff outputs before and after.Screenshots / Recordings
Not applicable (no UI changes).
Testing
ruff check digital_image_processing/morphological_operations/dilation_operation.py-> all checks passed (before and after)ruff check --select ALL ...-> 15 findings before, 6 after (D212 x4, COM812, CPY001 intentionally not fixed)ruff format --check-> already formattedpython -m pytest --doctest-modules digital_image_processing/morphological_operations/dilation_operation.py-> 10 doctests passedChecklist
Additional Notes
Not fixed on purpose: D212 (CONTRIBUTING's own example starts docstrings on the second line), COM812 (
pyproject.tomlmarks COM as "DO NOT FIX"), CPY001 (the repo uses no per-file copyright headers). Observation, not changed:dilation()only handles 3x3 kernels; for a 1x3 kernel the padding copy is empty and two existing doctests record all-False results that are wrong (see REVIEW.md).