Repository navigation
Update Ruff fork dependencies to rustpython-0.17.5 - #9831
Merged
Merged
Conversation
Retain explicit stacker support and existing compatibility patches. Assisted-by: Codex:gpt-6.1-sol
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
youknowone
marked this pull request as ready for review
November 14, 2026 01:15
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update all four Ruff dependencies from
9290a884to the publishedrustpython-0.17.5baselineb5960a1a15cd7a758c8e7df1b3b9d93f00288a16. Explicitly enable the now-optional parserstackerfeature to preserve existing stack growth. Retain all compiler/VM diagnostics and fork AST extensions.RustPython/ruff#7 remains open against this release branch; its additional PEP 798/diagnostic patches are not included in this baseline pin. RustPython/ruff#9 is a separate dependent runtime-hook proposal and is also not included. Neither is being silently treated as merged.
Verification
Before rebasing onto current main
9a82f61ca, the same dependency change passed:-D warnings; unchanged Rust 1.100 warnings remained.-m test test_grammar test_syntax test_ast test_fstring: four modules passed, 430 tests, 17 skipped.The final rebase was conflict-free with no intervening main changes to Cargo.toml or Cargo.lock. Final locked/offline Cargo metadata and diff whitespace checks passed. Full runtime suites were not rerun locally after this rebase. The final head
270d039776be20199041c003883ad341deeeb829has now passed CI run 43521709370, including Linux/macOS/Windows Rust and Python tests, all three Clippy jobs, WASI tests, WASM checks, and cross-target checks. All 27 reported checks are complete: 26 succeeded and the base/head/CPython performance comparison was skipped. Windows C-API build/tests/doctests were also skipped within the successful Windows Rust-test job, so no Windows C-API or comparative performance validation is claimed.Same-environment old/new-pin CPython 3.15.2 comparison confirms improvements for
first(); match = valueand bareraisebefore a semicolon. Two pre-existing position differences remain unchanged: a match statement after a semicolon, and a malformed Unicode escape following a non-ASCII character. Test success does not establish complete CPython compatibility or justify deleting compatibility patches.AI assistance: OpenAI Codex prepared and validated this update.