Repository navigation
Fix Rust 1.100 Clippy diagnostics on main - #9822
Conversation
Keep the set iterable alive through mutation, preserve no-host ctypes branches, and scope platform-only dependencies to their users. Assisted-by: Codex:version-unavailable
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Assisted-by: Codex:version-unavailable
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merging this PR will not alter performance
Comparing Footnotes
|
Summary
Fix the Rust 1.100 Clippy failures on main that also block unrelated PRs (including #9816).
map(...).unwrap_or_default()withmap_or_default(supported by the project's Rust 1.99 MSRV).must_useattributes onExitCodefunctions and an unnecessary builtin-int clone.pasteto Windows and runtimejiffto non-Unix targets, matching their actual uses. The build-timejiffdependency is unchanged.No Unicode casing changes or CI/test skips are included.
Validation
-Dwarnings.-Dwarnings.Option/Result::map_or_defaultcompilation probe.The independent main Unicode checksum regression is not fixed by this lint-only PR.
AI assistance: OpenAI Codex inspected the diagnostics, implemented the cleanup, and ran verification. An independent Codex review caught and corrected the Windows
jiffdependency condition before publication.