Skip to content

Fix Rust 1.100 Clippy diagnostics on main - #9822

Merged
youknowone merged 2 commits into
RustPython:mainfrom
youknowdot:fix/rust-1.100-clippy
Nov 13, 2026
Merged

youknowone merged 2 commits into
RustPython:mainfrom
youknowdot:fix/rust-1.100-clippy

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

Fix the Rust 1.100 Clippy failures on main that also block unrelated PRs (including #9816).

  • Replace map(...).unwrap_or_default() with map_or_default (supported by the project's Rust 1.99 MSRV).
  • Remove redundant must_use attributes on ExitCode functions and an unnecessary builtin-int clone.
  • Preserve the set iterable's lifetime with a narrowly documented clone-lint allowance; retain both native and no-host ctypes branches.
  • Scope paste to Windows and runtime jiff to non-Unix targets, matching their actual uses. The build-time jiff dependency is unchanged.

No Unicode casing changes or CI/test skips are included.

Validation

  • Passed: CI most-features workspace Clippy with -Dwarnings.
  • Passed: C-API Clippy separately with -Dwarnings.
  • Passed: repository hooks and formatting; Rust 1.99 Option/Result::map_or_default compilation probe.
  • In progress: full workspace/C-API Rust tests and no-host WASM compilation.
  • Windows/macOS builds are left to CI; dependency conditions were statically cross-checked.

The independent main Unicode checksum regression is not fixed by this lint-only PR.

AI assistance: OpenAI Codex inspected the diagnostics, implemented the cleanup, and ran verification. An independent Codex review caught and corrected the Windows jiff dependency condition before publication.

Keep the set iterable alive through mutation, preserve no-host ctypes branches, and scope platform-only dependencies to their users.

Assisted-by: Codex:version-unavailable
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Assisted-by: Codex:version-unavailable
@youknowone
youknowone marked this pull request as ready for review November 13, 2026 03:08
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T03:08:40.993419Z
We couldn’t complete this review. Comment @codex review to try again.
752dac0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@youknowone
youknowone merged commit 9f6a743 into RustPython:main Nov 13, 2026
23 of 27 checks passed
@codspeed

codspeed Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:fix/rust-1.100-clippy (752dac0) with main (f1cc68e)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants