You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Simple patch that moves the NameAliases version parser to build.rs. This avoids embedding the text file just to parse the file line each time unicode_version() is called.
I also fixed version_owner to allocate less by not constructing a temporary String to turn into a CString.
Unicode version reporting now consistently reflects the version bundled with the application, including for modern and legacy data views. This keeps reported version information aligned with the Unicode data available at runtime.
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.
Reviewing files that changed from the base of the PR and between f6631da and 419664d.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The build script now extracts the modern Unicode version at compile time. The Unicode library exposes modern and legacy version constants, and the standard library uses them for its Unicode version values.
Changes: Unicode version source and consumers
Layer / File(s)
Summary
Build-time version extraction crates/unicode/build.rs
The build script validates the version from the first line of NameAliases.txt and emits it as UNICODE_VERSION. It runs this parser alongside the block parser in small_parsers.
Unicode version constants and accessors crates/unicode/src/data.rs, crates/unicode/src/lib.rs
The Unicode library defines and re-exports UNICODE_VERSION and UNICODE_VERSION_LEGACY. Ucd::unidata_version() returns the applicable constant. The version test checks the modern constant, and the former unicode_version() function is removed.
Standard-library version values crates/stdlib/src/unicodedata.rs
Ucd::new initializes its version from the modern or legacy constant. The module-level unidata_version returns UNICODE_VERSION. CString construction panics if the selected value contains an internal NUL.
RustPython/RustPython#9406: It changes the same Unicode version source and public re-export that this PR replaces with compile-time constants.
RustPython/RustPython#9458: It adds and schedules the generate_blocks parser, which this PR moves into small_parsers and schedules there.
Suggested reviewers:youknowone, youknowdot
Merge Risk: Minimal · previous review f6631
The change moves Unicode version extraction to build time and removes a per-call allocation and parse. No actionable merge-blocking risk was identified in the supplied changes.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "No alloc Unicode version" matches the main change. The PR moves the NameAliases version parsing to build.rs and embeds the version as the compile-time constants UNICODE_VERSION and UNICODE_…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "No alloc Unicode version" matches the main change. The PR moves the NameAliases version parsing to build.rs and embeds the version as the compile-time constants UNICODE_VERSION and UNICODE_VERSION_LEGACY, so unicode_version() no longer parses the text file or allocates at runtime. The title is short and specific. It does not name the build-time change, but it points to the core purpose, and a teammate scanning history would understand the primary change.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between dba7a05 and f6631da.
Files selected for processing: 4
crates/stdlib/src/unicodedata.rs
crates/unicode/build.rs
crates/unicode/src/data.rs
crates/unicode/src/lib.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Simple patch that moves the NameAliases version parser to build.rs. This
avoids embedding the text file just to parse the file line each time
unicode_version() is called.
I also fixed version_owner to allocate less by not constructing a
temporary String to turn into a CString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple patch that moves the NameAliases version parser to build.rs. This avoids embedding the text file just to parse the file line each time unicode_version() is called.
I also fixed version_owner to allocate less by not constructing a temporary String to turn into a CString.
One of checkbox below must be checked.
Summary by CodeRabbit