You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
No alloc in lookup_alias/lookup_named_sequence - #9819
The original code allocated for case insensitive comparison. Instead, I iterate through both strings' bytes and convert the bytes to uppercase for the comparison. This has the added benefit of only iterating once in total. The old code iterated at least three times (once per each string pair and then a third time to compare).
The original code allocated for case insensitive comparison. Instead, I
iterate through both strings' bytes and convert the bytes to uppercase
for the comparison. This has the added benefit of only iterating once in
total. The old code iterated at least three times (once per each string
pair and then a third time to compare).
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.
No actionable comments were generated in the recent review.
Walkthrough
Alias and named-sequence binary searches now compare names with ASCII-uppercased byte iterators. They no longer build uppercased String keys.
Changes: Unicode name lookups
Layer / File(s)
Summary
Compare names without allocating folded strings crates/unicode/src/data.rs
cmp_caseless compares ASCII-uppercased bytes. Alias and named-sequence binary searches use this comparison. The searches retain case-insensitive ASCII ordering.
This change removes allocations from alias and named-sequence lookups without altering the ordering contract. No actionable merge risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "No alloc in lookup_alias/lookup_named_sequence" names the two functions whose case-insensitive comparison changed. The raw summary says the binary searches now compare ASCII-uppercased byte…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "No alloc in lookup_alias/lookup_named_sequence" names the two functions whose case-insensitive comparison changed. The raw summary says the binary searches now compare ASCII-uppercased byte iterators directly instead of building an uppercased String key, which removes the allocation the title describes. The title states the main goal and names the affected functions, so it fully matches the changeset.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between dba7a05 and 0d005a6.
Files selected for processing: 1
crates/unicode/src/data.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code allocated for case insensitive comparison. Instead, I iterate through both strings' bytes and convert the bytes to uppercase for the comparison. This has the added benefit of only iterating once in total. The old code iterated at least three times (once per each string pair and then a third time to compare).
One of checkbox below must be checked.
Summary by CodeRabbit