Repository navigation
Reject oversized bytearray resize requests - #9815
Merged
youknowone merged 1 commit intoNov 12, 2026
Merged
youknowone merged 1 commit into
youknowone merged 1 commit into
Conversation
Match CPython 3.15's normal bytes-allocation ceiling before allocating a resized bytearray. Preserve the same-size and exported-buffer checks, and cover the first excluded length, contents preservation, and export precedence on either pointer width. Assisted-by: Codex:unreported
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
youknowone
approved these changes
Nov 12, 2026
youknowone
marked this pull request as ready for review
November 12, 2026 09:12
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject bytearray resize requests above CPython 3.15's normal GIL-build bytes allocation limit before allocating. Keep same-size no-ops and exported-buffer errors ahead of the allocation check.
The failure appeared after #9807 enabled
test_bytes.test_resize. On 32-bit WASI, the existing Vec-backed implementation can successfully allocatesys.maxsizebytes. I reproduced that on a pre-#9813 build; the bytearray source is identical on current main and the failing #9813 CI merge.The fix is seven Rust lines. The snippet covers the first forbidden length on either pointer width, preservation of contents, and BufferError precedence. No
Libtests or workflow settings change.Reference: CPython 3.15 bytearray size ceiling and resize ordering, resize implementation.
Validation
test_bytes: 332 tests, 18 skipped, success. Focused resize selection: 2 tests passed.test_bytes, and snippet harness are queued behind existing shared builds. This remains a draft until those checks and CI finish.AI assistance: OpenAI Codex investigated, implemented, reviewed, and tested this change. The runtime did not expose an exact model version.