You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Run WASI suites through the standard test runner - #9804
Run WASI stdlib suites with the standard -m test runner through the same launcher used by snippets.
Set the guest PWD to the mounted checkout. RustPython already uses this variable for WASI startup; Wasmer's --cwd does not change WASI preview 1's cwd.
Use -X frozen_modules=off so traceback and source-sensitive tests read the checkout rather than frozen modules. Keep the standard resource policy explicit with -u none.
Add test_unpack, test_unpack_ex, test_ntpath, test_calendar, test_math, test_hashlib, and test_unicodedata. Re-enable the passing builtin_hash, builtin_open, and stdlib_types snippets.
No CPython test files or interpreter behavior are changed. CPU-heavy and other opt-in resource tests remain disabled. test_sort, threading, mmap, and network expansion are outside this change.
Validation
Built the current-main WASI binary with the workflow's exact feature set and ran it with Wasmer 7.5.0.
Source-backed stdlib regression: 78 of 78 suites passed (all 71 existing suites plus the 7 additions).
Verified checkout cwd, readable absolute sys.executable, nonzero exit for a deliberately failing suite (2), and exact propagation of SystemExit(17).
bash -n, actionlint, pre-commit hooks, and git diff --check pass. Zizmor reports the same four pre-existing low-severity self-repository findings as main, with no new findings.
Native workspace/C-API tests and clippy are still pending on the companion implementation change. Remote CI is pending.
AI assistance: Codex assisted with implementation, validation, and this PR description. The runtime did not expose an exact model version.
Summary by CodeRabbit
Tests
Expanded WebAssembly (WASI) test coverage to include additional standard-library areas, including math, hashing, Unicode, calendar, path handling, and unpacking.
Updated test selection and execution to run under the default resource policy, with CPU-heavy, network, and other opt-in resources disabled.
Set the working directory consistently when running tests in the WASI environment.
No actionable comments were generated in the recent review.
Walkthrough
The WASI CI workflow changes its snippet exclusions and Lib/test selection. It runs selected tests through the WASI wrapper with frozen modules disabled and the default resource policy. The wrapper sets PWD to the repository root for Wasmer.
Changes: WASI CI
Layer / File(s)
Summary
WASI test selection and execution .github/workflows/ci.yaml, extra_tests/rustpython_wasi.sh
The workflow updates snippet exclusions and adds seven Lib/test suites. It runs tests through the WASI wrapper with frozen modules disabled. The wrapper passes the repository root as PWD to Wasmer.
This change only adjusts how WASI test suites run in CI, so it does not change shipped behavior. No concrete merge-blocking risk was found. Confirm that remote CI passes before merging.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: running WASI test suites through the standard test runner.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 4e1c5d3 and d2ebb19.
Files selected for processing: 1
.github/workflows/ci.yaml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Use the mounted checkout as the guest working directory and load source-backed tests through regrtest. Add seven suites and restore three passing snippets without changing CPython tests.
Assisted-by: Codex:unreported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-m testrunner through the same launcher used by snippets.PWDto the mounted checkout. RustPython already uses this variable for WASI startup; Wasmer's--cwddoes not change WASI preview 1's cwd.-X frozen_modules=offso traceback and source-sensitive tests read the checkout rather than frozen modules. Keep the standard resource policy explicit with-u none.test_unpack,test_unpack_ex,test_ntpath,test_calendar,test_math,test_hashlib, andtest_unicodedata. Re-enable the passingbuiltin_hash,builtin_open, andstdlib_typessnippets.No CPython test files or interpreter behavior are changed. CPU-heavy and other opt-in resource tests remain disabled.
test_sort, threading, mmap, and network expansion are outside this change.Validation
sys.executable, nonzero exit for a deliberately failing suite (2), and exact propagation ofSystemExit(17).bash -n,actionlint, pre-commit hooks, andgit diff --checkpass. Zizmor reports the same four pre-existing low-severityself-repositoryfindings as main, with no new findings.AI assistance: Codex assisted with implementation, validation, and this PR description. The runtime did not expose an exact model version.
Summary by CodeRabbit