Skip to content

Match generated Python 3.15 signature defaults and names - #9795

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/generated-signatures-split-20261111
Nov 11, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/generated-signatures-split-20261111

Conversation

@youknowdot

@youknowdot youknowdot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Split the generator-supported corrections out of #9756, as requested in #9756 (comment). This PR is based directly on main and does not depend on the deferred override work.

  • Match symbolic/default spelling in array, blake2, codecs, faulthandler, marshal, select, warnings, and IO seek.
  • Correct _imp.create_dynamic and struct-sequence parameter names.
  • Match the Future/Task add_done_callback context default. Preserve the runtime distinction: omission copies the registration context, while explicit None reaches call_soon and uses the completion context.
  • Correct _csv.register_dialect's invalid-name error text, retaining name validation before dialect validation.

The grouped str/bytes/bytearray signatures and CSV display overrides remain in #9756. There is no py_optional_group, DefaultRepr::OptionalGroup, or display-only FromArgs metadata in this PR.

Validation

At final head 113460dd9:

  • Configured commit hooks passed.
  • Workspace Rust tests and doctests passed (1,540 passed, 20 ignored across their reported groups).
  • C-API tests passed (149 passed, 2 ignored).
  • Strict workspace/all-target and separate C-API Clippy passed.
  • Release build passed.
  • All three affected signature/asyncio/CSV snippets passed on RustPython and CPython 3.15.1; the three selected RustPython pytest cases passed.
  • Standard-library regression run passed: test_array test_structseq test_hashlib test_select test_codecs test_warnings test_marshal test_faulthandler test_inspect test_csv test_io test_asyncio.test_futures test_asyncio.test_context, covering 21 files, 3,573 tests run and 225 skipped.
  • Both split branches merge cleanly and preserve all original Python test statements from Add checked legacy Python 3.15 text signature overrides #9756 across the two PRs.

Local validation used a clean rebuild of every workspace package after discarding stale cross-worktree artifacts. No source fix or extra push was needed. GitHub CI is tracked separately; its final results are not claimed here.

AI assistance

Split, implementation review, and validation were performed with Codex. This reuses the generator-supported changes from #9756 and preserves their regression tests.

Split the generator-supported corrections from the legacy display overrides in RustPython#9756. Preserve the callback context distinction between omission and explicit None, and fix CSV invalid-name error text.

Assisted-by: OpenAI Codex: model version not exposed
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codspeed

codspeed Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:fix/generated-signatures-split-20261111 (113460d) with main (dd8c343)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@youknowone
youknowone marked this pull request as ready for review November 11, 2026 14:06
@youknowone
youknowone merged commit 5713e58 into RustPython:main Nov 11, 2026
29 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T14:06:46.986973Z
We couldn’t complete this review. Comment @codex review to try again.
113460d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants