Repository navigation
Match generated Python 3.15 signature defaults and names - #9795
youknowone merged 1 commit into
Conversation
Split the generator-supported corrections from the legacy display overrides in RustPython#9756. Preserve the callback context distinction between omission and explicit None, and fix CSV invalid-name error text. Assisted-by: OpenAI Codex: model version not exposed
|
Caution Review failedThe pull request is closed. Pre-merge checks:
|
Merging this PR will not alter performance
Comparing Footnotes
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Split the generator-supported corrections out of #9756, as requested in #9756 (comment). This PR is based directly on
mainand does not depend on the deferred override work.seek._imp.create_dynamicand struct-sequence parameter names.add_done_callbackcontext default. Preserve the runtime distinction: omission copies the registration context, while explicitNonereachescall_soonand uses the completion context._csv.register_dialect's invalid-name error text, retaining name validation before dialect validation.The grouped
str/bytes/bytearraysignatures and CSV display overrides remain in #9756. There is nopy_optional_group,DefaultRepr::OptionalGroup, or display-onlyFromArgsmetadata in this PR.Validation
At final head
113460dd9:test_array test_structseq test_hashlib test_select test_codecs test_warnings test_marshal test_faulthandler test_inspect test_csv test_io test_asyncio.test_futures test_asyncio.test_context, covering 21 files, 3,573 tests run and 225 skipped.Local validation used a clean rebuild of every workspace package after discarding stale cross-worktree artifacts. No source fix or extra push was needed. GitHub CI is tracked separately; its final results are not claimed here.
AI assistance
Split, implementation review, and validation were performed with Codex. This reuses the generator-supported changes from #9756 and preserves their regression tests.