Repository navigation
Normalize source newlines before warnings, compilation and diagnostics - #9793
Merged
youknowone merged 2 commits intoNov 11, 2026
Merged
Conversation
…tion Share universal-newline translation across byte decoding, compiler entry points and syntax diagnostics. Keep LF-only input borrowed and preserve original compile audit bytes. Cover literal values, docstrings, warnings and diagnostic consistency. Assisted-by: OpenAI Codex:GPT-6.1
Contributor
Pre-merge checks:
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
This assessment has not completed. The check will be retried on the next pre-merge check run. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Assisted-by: OpenAI Codex:GPT-6.1
youknowone
marked this pull request as ready for review
November 11, 2026 02:36
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
youknowone
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize CRLF and lone CR before parser warnings and compilation, including physical newlines inside string literals. This follows CPython 3.15's
_PyTokenizer_translate_newlines/_PyTokenizer_FromUTF8ordering.This is an independent alternative to close #9762, not stacked on it. The original change fixes literal values but runs after VM parser warnings and leaves diagnostics reading the untranslated input.
compileaudit events.Verification
builtin_compile.py/builtin_compile_module.py: pytest 4 passed.test_compile: passed (187 tests run, 51 skipped).-cphysical-CR literal checks: passed.-D warnings: passed.This does not claim full parser diagnostic parity: existing LF-input differences in trailing newlines in
SyntaxError.textand warning-as-error precedence for invalid source also remain for CR input. This patch makes the newline forms consistent; it does not hide those independent differences.AI assistance: OpenAI Codex.