Skip to content

Make slice reference mismatches fail the snippet #9746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Nov 8, 2026
Merged

Make slice reference mismatches fail the snippet #9746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extra_tests/snippets/builtin_slice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,15 +191,15 @@ def test_all_slices():
except AssertionError:
failures.append(
"start: {} ,stop: {}, step {}. Expected: {}, found: {}".format(
s, e, t, lhs, slices_res[count]
s, e, t, slices_res[count], lhs
)
)
count += 1

if failures:
for f in failures:
print(f)
print(len(failures), "slices failed")
raise AssertionError(f"{len(failures)} slices failed")

@chatgpt-codex-connector chatgpt-codex-connector Bot Nov 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the existing snippet test logic

Replacing the summary print with raise changes the pass/fail logic of the existing test_all_slices(). Root AGENTS.md explicitly says “NEVER modify test assertions, test logic, or test data”; this restriction applies to snippet tests too. Preserve the existing function and add separate fail-on-mismatch coverage using the permitted new-test approach, or obtain an explicit policy exception before changing its logic.

AGENTS.md reference: AGENTS.md:L278-L278

Useful? React with 👍 / 👎.



test_all_slices()
Loading