Skip to content

Preserve symbolic buffer defaults in IO text signatures #9744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Nov 9, 2026
Merged

Preserve symbolic buffer defaults in IO text signatures #9744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa06dbb
Preserve symbolic buffer defaults in IO text signatures
codex Nov 7, 2026
bfb3df3
Use the shared IO buffer constant for constructor defaults
codex Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/vm/src/stdlib/_io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,15 +969,15 @@ mod _io {
#[derive(FromArgs, Clone)]
struct BufferSize {
// 128 * 1024, the module buffer size.
#[pyarg(any, default = 131072)]
#[pyarg(any, default = DEFAULT_BUFFER_SIZE as isize, py_default = "DEFAULT_BUFFER_SIZE")]
buffer_size: isize,
}

#[derive(FromArgs)]
struct BufferedInitArgs {
#[pyarg(any)]
raw: PyObjectRef,
#[pyarg(any, default = 131072)]
#[pyarg(any, default = DEFAULT_BUFFER_SIZE as isize, py_default = "DEFAULT_BUFFER_SIZE")]
buffer_size: isize,
}

Expand All @@ -987,7 +987,7 @@ mod _io {
reader: PyObjectRef,
#[pyarg(positional)]
writer: PyObjectRef,
#[pyarg(positional, default = 131072)]
#[pyarg(positional, default = DEFAULT_BUFFER_SIZE as isize, py_default = "DEFAULT_BUFFER_SIZE")]
buffer_size: isize,
}

Expand Down
18 changes: 18 additions & 0 deletions extra_tests/snippets/builtin_signature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,21 @@
"($module, /, path, times=None, *, ns=<unrepresentable>, "
"dir_fd=None, follow_symlinks=True)"
)

# Buffered stream constructors retain Clinic's symbolic module default.
import _io

for stream_type in (_io.BufferedReader, _io.BufferedWriter, _io.BufferedRandom):
assert stream_type.__text_signature__ == "(raw, buffer_size=DEFAULT_BUFFER_SIZE)"
assert (
inspect.signature(stream_type).parameters["buffer_size"].default
== _io.DEFAULT_BUFFER_SIZE
)

assert _io.BufferedRWPair.__text_signature__ == (
"(reader, writer, buffer_size=DEFAULT_BUFFER_SIZE, /)"
)
assert (
inspect.signature(_io.BufferedRWPair).parameters["buffer_size"].default
== _io.DEFAULT_BUFFER_SIZE
)
Loading