Skip to content

Expand WASI coverage with validated CPython tests and snippets - #9743

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:ci/wasi-coverage-20261108
Nov 8, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:ci/wasi-coverage-20261108

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

Expand the existing WASI job without another build or matrix entry:

  • Run 14 more CPython 3.15 test modules: array, bool, bytes, codecs, complex, enumerate, float, list, long, memoryview, range, set, slice, and tuple.
  • Re-enable the existing builtin_iter, builtin_map, and stdlib_json snippets.
  • Keep the existing assertions, skips, expected failures, execution options, and job timeout unchanged.

The added unittest modules collect 2,955 cases, including 156 existing skips and 6 expected failures. They take about 46 seconds in the local Wasmer run. This expands coverage; it is not a claim of complete CPython compatibility.

Validation

  • Built latest main with the CI WASI target, wasm-release profile, and identical feature set using Rust 1.99.0.
  • Executed the tests with Wasmer 7.5.0 and the workflow's volume mapping and per-file commands.
  • Replayed the full selected workflow: all 190 snippets and 26 unittest module invocations exited successfully (including existing skips/expected failures).
  • actionlint 1.7.12 and pre-commit hooks pass.
  • zizmor 1.32.0: same four low-severity self-repository findings as unchanged main; no new findings.
  • Native workspace/CAPI aggregate tests and Clippy have not been rerun locally for this workflow-only change; GitHub CI remains required.

AI assistance: OpenAI Codex investigated the WASI coverage, made the workflow-only edit, ran the local checks, and performed an independent review.

Exercise 14 additional CPython 3.15 test modules and restore three passing snippets without adding builds or relaxing tests.

Assisted-by: OpenAI Codex:version-unavailable
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jiwahn

@youknowone
youknowone marked this pull request as ready for review November 8, 2026 04:04
@youknowone
youknowone merged commit 4544177 into RustPython:main Nov 8, 2026
28 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T04:07:23.844088Z 3da11e6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants