Skip to content

Track PickleBuffer reference cycles #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Nov 7, 2026
Merged

Track PickleBuffer reference cycles #9733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d6fc12
Track PickleBuffer exporter references during cyclic GC
codex Nov 6, 2026
48baa9d
Retire the remaining PickleBuffer expected failure
codex Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Lib/test/test_picklebuffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ def test_release(self):
# Idempotency
pb.release()

@unittest.expectedFailure # TODO: RUSTPYTHON; PickleBuffer is not traversed by the cycle collector
def test_cycle(self):
b = B(b"foo")
pb = PickleBuffer(b)
Expand Down
2 changes: 1 addition & 1 deletion crates/stdlib/src/pickle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ mod _pickle {
// PickleBuffer

#[pyattr]
#[pyclass(module = "pickle", name = "PickleBuffer")]
#[pyclass(module = "pickle", name = "PickleBuffer", traverse)]
#[derive(Debug, PyPayload)]
pub(super) struct PyPickleBuffer {
buffer: PyRwLock<Option<PyBuffer>>,
Expand Down
Loading