Repository navigation
Clear remaining LZMA expected failures - #9732
Merged
youknowone merged 3 commits intoNov 6, 2026
Merged
Conversation
Report unsupported or invalid XZ check IDs as LZMAError rather than ValueError, preserving the liblzma diagnostics for reserved and out-of-range identifiers. Assisted-by: OpenAI Codex: model version not exposed
Match CPython ValueError diagnostics after compressor flush and report invalid delta property distances as LZMAError. These cover the deeper failures in the remaining canonical LZMA tests. Assisted-by: OpenAI Codex: model version not exposed
Run scripts/update_lib quick Lib/test/test_lzma.py --no-build --no-commit against the corrected interpreter. All 121 canonical tests pass with one existing skip and no remaining expected failures. No assertions or test logic change. Assisted-by: OpenAI Codex: model version not exposed
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [x] lib: cpython/Lib/lzma.py dependencies:
dependent tests: (118 tests)
Legend:
|
youknowone
approved these changes
Nov 6, 2026
youknowone
marked this pull request as ready for review
November 6, 2026 23:43
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
youknowdot
pushed a commit
to youknowdot/RustPython
that referenced
this pull request
Nov 6, 2026
Use scripts/update_lib quick Lib/test/test_picklebuffer.py --no-build --no-commit after enabling exporter traversal. All nine canonical tests pass with the three existing _testbuffer availability skips; no assertions, test logic, or skips change. Keep this validated stack from launching redundant hosted CI while RustPython#9732 is pending. Assisted-by: OpenAI Codex: model version not exposed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LZMAError, matching CPython 3.15: reserved check IDs reportUnsupported integrity check; out-of-range IDs reportInternal error.ValueErrorwith CPython messages when compressing or flushing an already-flushed compressor; report invalid delta property distances asLZMAError("Internal error").test_lzma.pyas one whole-file batch.scripts/update_lib quick Lib/test/test_lzma.py --no-build --no-commit. No assertions, test data, test logic, snippets, skips, or workflow files are changed.Validation
stdlib,stdio,importlib,host_env,doc,threading,sqliteand no default features.test_lzma: 121 tests, one unchanged CPython-only reference-leak skip, zero expected failures. The existingextra_tests/snippets/stdlib_lzma.pyalso passed.-D warnings.Hosted CI and native non-Linux/platform-specific execution remain pending; this PR stays draft.
Integration
Based on main
f1f38c1594. This fixes a remaining error conversion also present in #8639's alternative LZMA backend; that port should preserve the correction when rebased. This does not broaden the pre-existing preset/filter-versus-check validation order or the state transition after a failed flush.AI assistance: OpenAI Codex performed source inspection, the narrow correction, independent review, and validation. The exact model version was not exposed.