Repository navigation
Handle fallible filesystem decoding in Windows console IO - #9728
Merged
youknowone merged 1 commit intoNov 6, 2026
Merged
Conversation
Keep console detection best-effort when filesystem decoding fails and propagate decoding errors when initializing WindowsConsoleIO. This fixes both E0308 match-arm errors on current main without suppressing lints. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
youknowone
approved these changes
Nov 6, 2026
youknowone
marked this pull request as ready for review
November 6, 2026 03:52
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the two Windows
E0308errors in main's Clippy job. Both bytes-path branches still treated the now-falliblevm.fsdecoderesult as a string.\0if decoding fails during best-effort console detection, consistent with the adjacent path-conversion failure handling._WindowsConsoleIOinitialization with?.Only these two call sites change. No lint suppression, workflow changes, or test changes.
Validation
cargo fmt --check, normal commit hooks, andgit diff --checkpassed.clipboard-win v5.4.1; the installed toolchain also lacks the Windows target. Native Windows compilation, the workspace suite, and C-API tests remain unrun. Hosted CI must validate the actual Windows build.Based on main
0dd06b08e13f79ad19d32c8f5820953a05a6be81.AI assistance: OpenAI Codex diagnosed the CI failure, implemented and reviewed the fix, and performed the listed local checks. Model version is not exposed.