Repository navigation
Fix inherited main Clippy failures - #9724
Closed
youknowdot wants to merge 1 commit into
Closed
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Preserve platform-dependent ancillary header conversions and the execve environment snapshot. Make the ancillary test module explicitly test-only and apply equivalent Clippy style fixes in socket tests and ElementTree. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #9725, merged into main at
a2cd289056adb917e795dc9022e3086c5a05166f. All functional fixes are covered; the only remaining differences are explanatory wording andexpectversusallowfor the intentional POSIX snapshot.Summary
Fix the strict Clippy failures inherited from
main, without changing interpreter behavior:cmsghdr.cmsg_lenconversion and explain its narrowly scoped lint allowance.#[cfg(test)]and use equivalent alignment/range expressions, retaining every assertion.needless_collectexpectation.Selfand inline format arguments in ElementTree.The patch is 3 files, +13/-7. Base:
08af9f472a471a8be543529f688f15421f49532f.Verification
host_envdiagnostics, including the platform cast and ancillary tests.cargo clippy --offline --locked --keep-going -j1 --features capi,encodings,jit,sqlite,threading --workspace --all-targets --bins --examples --tests --exclude rustpython_wasm --exclude rustpython-venvlauncher -- -Dwarningson GNU/Linux, Rust 1.99.0.cargo test --offline --locked -j1 -p rustpython-host_env: 21 passed, including all five ancillary parser tests; doc tests passed.cargo test --offline --locked -j1 --workspace --exclude rustpython_wasm --exclude rustpython-venvlauncher --exclude rustpython-capipassed: 1,483 tests/doctests passed, 20 existing ignored, zero failures. Local environment needed a task-local linker alias for installed libffi.so.8 and disk cleanup. Debug symbols were stripped only from completed example binaries; all loadable ELF sections were verified unchanged.expectversusallowfor the intentional POSIX snapshot.Main's existing CI run independently reproduces the three ElementTree diagnostics on Linux, macOS, and Windows with Rust 1.99.1. This environment can run Linux only; cross-platform results will come from CI.
AI disclosure
OpenAI Codex assisted with investigation, code changes, source review, and validation. No behavior changes or test assertions were generated.