Repository navigation
Share typing representation and GenericAlias controls - #9711
Merged
youknowone merged 3 commits intoNov 6, 2026
Merged
Conversation
Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Use one writer for aliases, unions, and constant annotations while preserving Unicode, returned string callbacks, and temporary owner order. Assisted-by: OpenAI Codex:model version not exposed
Override the existing rich comparison slot through Comparable, preserving raw equality results and identity-based inequality. Retain a bool-valued cmp adapter for Rust callers without duplicating comparison logic. Assisted-by: OpenAI Codex:model version not exposed
youknowone
approved these changes
Nov 6, 2026
youknowone
marked this pull request as ready for review
November 6, 2026 12:50
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align GenericAlias controls and share the Python 3.15 type-representation writer across GenericAlias, Union and constant annotation evaluators. The combined change spans three Rust files (+163/-182).
__str__call on returned str subclasses, after name-attribute cleanup. This call can change output or raise and must not be replaced with raw string copying.(int)for a singleton tuple, and preserve Unicode in ConstEvaluator's own repr and Union's subclassing diagnostic.Validation
Pinned reference: CPython d220409a13b77de7a6c30abe16ea90db01528edc, including typevarobject.c, genericaliasobject.c and unicode_writer.c.
Limits and integration
Native RustPython execution remains unperformed because its required safety guard is not verified; hosted runtime CI remains necessary. The separate non-threaded/WASM graph and full workspace/C-API test suite were not run under the current disk constraint. No repository tests, markers, Lib files or workflows changed.
#9714 separately fixes Union construction and comparison; #9687 fixes TypeAliasType constructor binding; #9700 changes qualified-name diagnostics. Exact-source composition with those changes was clean and reviewed, but the combined branches were not compiled. Broader payload ownership work in #8944/#8939 may require textual reconciliation and does not implement these controls.