Repository navigation
Align TypeAliasType constructor binding and validation - #9687
youknowone merged 1 commit into
Conversation
Reuse shared raw argument binding, validate native type parameters before reading defaults, and preserve callback exceptions and WTF-8 diagnostics. Normalize empty parameter tuples while retaining inputs through allocation, and derive caller module metadata from the existing function-frame API. Assisted-by: OpenAI Codex:model version not exposed
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Merging this PR will not alter performance
Comparing Footnotes
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Reference: CPython 3.15.0 TypeAliasType construction and type-parameter validation and generated Clinic wrappers.
Validation
cargo check --locked --offline -j1 -p rustpython-host_env -p rustpython-vm -p rustpython-stdlib --features rustpython-stdlib/threadingpassed.-- -D warningspassed. This is a focused threading-enabled subset of CI, not the full workspace/all-targets suite.Shared-binder mixed-invalid error precedence and wording remain different from Clinic in some combinations. This change adds no bespoke parser or VM frame architecture changes, and is independent of the TypeVar constructor group.
AI assistance: OpenAI Codex performed source comparison, implementation, reference probes and independent source review; model version was not exposed.