Repository navigation
Align partial construction and state controls - #9679
youknowone merged 3 commits into
Conversation
Preserve nested keyword ownership and lazy instance dictionaries, use native Placeholder identity, and share constructor argument binding. Validate restored state before callback conversion, retain instance dict identity, and copy stored keyword entries without rehashing keys. Assisted-by: OpenAI Codex:model version not exposed
PosArgs exposes its borrowed slice through AsRef rather than as_slice. Assisted-by: OpenAI Codex:model version not exposed
Avoid a redundant strong reference when constructing a nonnested partial. Assisted-by: OpenAI Codex:model version not exposed
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Merging this PR will not alter performance
Comparing Footnotes
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Invalid state is rejected before mutation. Successful field replacement remains sequential, matching CPython rather than claiming transactional reentrant updates.
Reference: CPython 3.15.0 partial construction and state restoration.
Validation
rustpython-stdlib/threadingpassed. Normal repository commit hooks passed.AI assistance: OpenAI Codex performed source comparison, implementation, reference probes, and independent source review; model version was not exposed.