Share POSIX IDs and prepare subprocess inputs by youknowdot · Pull Request #9677 · RustPython/RustPython

youknowdot · 2026-11-03T23:47:13Z

Summary

Group the shared POSIX account converters with the subprocess preparation that consumes them.

Reuse UID/GID conversion for POSIX controls, pwd.getpwuid, grp.getgrgid, and _posixsubprocess, including index-enabled values, C-long overflow behavior, and the -1 sentinel.
Match subprocess scalar-binding and parent-preparation order: preexec restrictions, error-pipe and sorted-descriptor validation, executable/argv/environment/cwd conversion, groups, IDs, then audit.
Emit _posixsubprocess.fork_exec with the original executable, argv, and environment objects after native preparation and before fork. Accept args=None, distinguish bytes-only executable/environment sequences from filesystem paths, and retain live argv mutation checks and converted bytes lifetimes.
Keep user descriptors as raw integers rather than inventing BorrowedFd<'static> validity. Typed host APIs share the same implementation; child syscall order, credential order, and error-pipe serialization remain unchanged.

References: CPython 3.15.0 _posixsubprocess, Clinic binding, ID converters, pwd, and grp.

Validation

Focused stdlib build and strict all-target VM/host-env/stdlib Clippy with threading passed.
Four native host tests passed: invalid descriptor errors, early setup rejection, raw/borrowed keep-list agreement, and isolated owned-pipe inheritance/write/dup behavior. These tests do not fork, exec, run a VM, change credentials, or redirect standard streams.
Normal repository commit hooks, rustfmt, and whitespace checks passed.
Independent source review covered callback/error order, list mutation, bytes-subclass lifetime, audit identity, pointer lifetime, and raw-FD syscall order. CPython-only reference probes were intercepted by an audit hook before fork.

Remaining scope

Local RustPython runtime and full workspace/C-API suites were not run. Hosted macOS CI subsequently observed AuditTest.test_posixsubprocess passing, so its remaining conditional expected-failure marker was retired through scripts/update_lib. Test bodies are unchanged; Windows skips this test because _posixsubprocess is unavailable. Fresh CI must validate the updated head.

The compile-time extra-group cap is supplied for Linux GNU, macOS, FreeBSD, and NetBSD. Other targets retain their existing uncapped preparation; runtime sysconf is not substituted for CPython's header constant. Existing preexec GC/fork callbacks and child algorithms are outside this patch. The shared iterable collector's partial-result destruction order when iteration itself fails is also unchanged.

AI assistance: OpenAI Codex performed source comparison, implementation, reference probes, validation, and independent source review; model version was not exposed.

Reuse common UID and GID converters for POSIX controls and account lookups. Honor index-enabled arguments, C-long conversion boundaries, and sentinel formatting while preserving lookup allocation errors. Assisted-by: OpenAI Codex:model version not exposed

Bring AsObject into pwd for exception classification and remove the obsolete POSIX PyObject import. Assisted-by: OpenAI Codex:model version not exposed

coderabbitai · 2026-11-03T23:47:19Z

Caution

Review failed

The pull request is closed.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Assisted-by: OpenAI Codex: model version not exposed

Match parent-side conversion and validation order while reusing the shared POSIX ID converters. Keep original audit objects, bytes-path lifetimes and live argv list mutation behavior; adapt child descriptors as raw integers without fabricated borrowed lifetimes. Add bounded host-only tests for descriptor errors and owned pipe operations. Assisted-by: OpenAI Codex: model version not exposed

Generate the platform-specific marker through update_lib from repeated exact-head hosted Linux XPASS evidence, preserving expectations for unverified platforms. Assisted-by: dot:frontier-intelligence

github-actions · 2026-11-05T00:53:12Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] test: cpython/Lib/test/test_sys.py (TODO: 4)
[x] test: cpython/Lib/test/test_syslog.py
[x] test: cpython/Lib/test/test_sys_setprofile.py (TODO: 1)
[x] test: cpython/Lib/test/test_sys_settrace.py
[x] test: cpython/Lib/test/test_audit.py (TODO: 12)
[x] test: cpython/Lib/test/audit-tests.py

dependencies:

dependent tests: (250 tests)

sys: regrtestdata test___all__ test__colorize test__locale test__osx_support test_android test_annotationlib test_argparse test_array test_asdl_parser test_ast test_asyncio test_audit test_base64 test_bdb test_bigaddrspace test_bigmem test_binascii test_bisect test_buffer test_builtin test_bytes test_bz2 test_c_locale_coercion test_calendar test_capi test_class test_clinic test_cmath test_cmd test_cmd_line test_cmd_line_script test_code test_code_module test_codeccallbacks test_codecs test_collections test_compile test_compileall test_complex test_concurrent_futures test_context test_contextlib test_coroutines test_crossinterp test_csv test_ctypes test_curses test_datetime test_dbm test_dbm_sqlite3 test_decimal test_descr test_dict test_difflib test_dis test_doctest test_docxmlrpc test_dtrace test_dynamic test_dynamicclassattribute test_email test_embed test_ensurepip test_enum test_enumerate test_eof test_epoll test_except_star test_exceptions test_external_inspection test_faulthandler test_fcntl test_file_eintr test_fileinput test_float test_fork1 test_format test_fractions test_frame test_free_threading test_frozen test_functools test_future_stmt test_gc test_generated_cases test_generators test_genericpath test_genexps test_getopt test_glob test_grammar test_gzip test_hash test_hashlib test_http_cookiejar test_httpservers test_importlib test_inspect test_int test_interpreters test_io test_ioctl test_iter test_itertools test_json test_launcher test_list test_listcomps test_locale test_logging test_long test_lzma test_mailbox test_marshal test_math test_memoryview test_metaclass test_mimetypes test_mmap test_monitoring test_msvcrt test_multibytecodec test_multiprocessing_forkserver test_multiprocessing_main_handling test_netrc test_ntpath test_numeric_tower test_opcache test_operator test_optparse test_ordered_dict test_os test_osx_env test_pathlib test_patma test_pdb test_peepholer test_perfmaps test_pickle test_pkg test_pkgutil test_platform test_plistlib test_popen test_posixpath test_print test_profile test_profiling test_property test_pty test_pwd test_py_compile test_pyclbr test_pydoc test_pyexpat test_pyrepl test_quopri test_raise test_range test_re test_readline test_regrtest test_remote_pdb test_repl test_reprlib test_resource test_runpy test_sax test_scope test_script_helper test_select test_selectors test_shutil test_signal test_site test_slice test_smtplib test_socket test_source_encoding test_sqlite3 test_ssl test_stable_abi_ctypes test_startfile test_stat test_statistics test_str test_strftime test_string_literals test_strptime test_strtod test_struct test_subprocess test_support test_sys test_sys_setprofile test_sys_settrace test_sysconfig test_syslog test_tabnanny test_tarfile test_tcl test_tempfile test_termios test_threading test_threading_local test_threadsignals test_time test_timeit test_tkinter test_tomllib test_tools test_trace test_traceback test_tracemalloc test_ttk test_tuple test_type_cache test_type_comments test_types test_typing test_unicode_file test_unicode_file_functions test_unicodedata test_unittest test_urllib test_urllib2 test_urllib2net test_urlparse test_utf8_mode test_uuid test_venv test_wait3 test_wait4 test_wave test_weakref test_webbrowser test_winconsoleio test_winreg test_with test_wsgiref test_xml_etree test_xmlrpc test_xpickle test_zipapp test_zipfile test_zipfile64 test_zipimport test_zipimport_support test_zlib

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

Use scripts/update_lib auto-mark helpers with the exact-head hosted CI results to retire only observed unexpected-success markers. Test bodies, assertions, and platform skips remain unchanged. Assisted-by: OpenAI Codex:model version not exposed

chatgpt-codex-connector · 2026-11-06T11:25:41Z

Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	❌ Failed 2026-11-06T11:25:38.074016Z We couldn’t complete this review. Comment `@codex review` to try again.	`4e37958`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-11-06T11:25:43Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

youknowdot added 2 commits November 4, 2026 08:41

Correct shared account converter imports

ee725a7

Bring AsObject into pwd for exception classification and remove the obsolete POSIX PyObject import. Assisted-by: OpenAI Codex:model version not exposed

youknowdot added 2 commits November 4, 2026 11:50

Merge current main before subprocess preparation

31be0cc

Assisted-by: OpenAI Codex: model version not exposed

youknowone changed the title ~~Share POSIX account ID conversion~~ Share POSIX IDs and prepare subprocess inputs Nov 4, 2026

Retire the passing Linux subprocess audit expectation

c8abe3b

Generate the platform-specific marker through update_lib from repeated exact-head hosted Linux XPASS evidence, preserving expectations for unverified platforms. Assisted-by: dot:frontier-intelligence

youknowone marked this pull request as ready for review November 6, 2026 11:25

youknowone merged commit 6b6fccf into RustPython:main Nov 6, 2026
29 checks passed

youknowdot mentioned this pull request Nov 6, 2026

Stabilize subprocess pipe descriptor fixtures #9735

Merged

1 task done

Navigation Menu

Repository navigation

Share POSIX IDs and prepare subprocess inputs - #9677

Share POSIX IDs and prepare subprocess inputs#9677
youknowone merged 6 commits into
RustPython:mainfrom
youknowdot:account-id-conversion-group-20261103

youknowdot commented Nov 3, 2026 •

edited by youknowone

Loading

Uh oh!

coderabbitai Bot commented Nov 3, 2026 •

edited

Loading

Review failed

Uh oh!

github-actions Bot commented Nov 5, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

youknowdot commented Nov 3, 2026 • edited by youknowone Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Remaining scope

Uh oh!

coderabbitai Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Uh oh!

github-actions Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Library Dependencies

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

youknowdot commented Nov 3, 2026 •

edited by youknowone

Loading

coderabbitai Bot commented Nov 3, 2026 •

edited

Loading

github-actions Bot commented Nov 5, 2026 •

edited

Loading