Repository navigation
Align Linux locale collation with Python 3.15 - #9674
Conversation
Use wide collation strings, retain surrogate code points, encode transform weights in Python 3.15 order, and preserve errno and allocation failures. AI-assisted implementation, source review, and validation using OpenAI Codex. Assisted-by: OpenAI Codex:model version not exposed
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00c405870f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| buff | ||
| } | ||
|
|
||
| #[cfg(target_os = "linux")] |
There was a problem hiding this comment.
The commit message explicitly states that implementation, source review, and validation were AI-assisted, but it contains no Assisted-by: trailer. AGENTS.md requires an Assisted-by: AGENT_NAME:MODEL_VERSION trailer for each AI tool; the free-form “AI assistance” section does not satisfy that attribution requirement. Add the required structured trailer to the commit message.
AGENTS.md reference: AGENTS.md:L23-L23
Useful? React with 👍 / 👎.
Summary
_locale.strcollandstrxfrmthrough wide-character collation, retaining lone surrogates and rejecting embedded NULs through a shared converter after normal argument binding.> 0x10000boundary; preserve individual surrogate weights and propagate libc errors separately from allocation failures.The current narrow UTF-8 route reverses comparisons in non-UTF-8 locales. In installed
sv_SE, comparingzwithäreturns positive through the current narrow call but negative through CPython's wide call. Reference probes found 24/100 ordering differences in each ofen_USandde_DE, and 36/100 insv_SE.Reference: CPython 3.15 collation implementation.
Validation
cargo checkfor host_env, vm and stdlib, withrustpython-stdlib/threading, locked/offline, one job.-D warnings).Native RustPython execution, full suites and other platforms were not run. No tests, standard-library Python files or workflows are changed. No >Unicode raw weights or invalid-UTF-8 narrow keys were observed; allocation-failure and concurrent-size-change branches were source-reviewed, not fault-injected.
AI assistance
Implementation, source review and validation were AI-assisted using OpenAI Codex (model version not exposed).