Repository navigation
Match binascii hex separator validation - #9643
Merged
youknowone merged 1 commit intoNov 7, 2026
Merged
Conversation
Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
youknowone
reviewed
Nov 6, 2026
| data: ArgBytesLike, | ||
| #[pyarg(any, optional)] | ||
| sep: OptionalArg<ArgAsciiBuffer>, | ||
| sep: OptionalArg<PyObjectRef>, |
youknowone
approved these changes
Nov 7, 2026
youknowone
marked this pull request as ready for review
November 7, 2026 11:58
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align
binascii.hexlifyandb2a_hexseparator validation with CPython's bytes-output path. Check the object's length first, then accept astrcontaining only Latin-1 code points or abytesobject, including subclasses. This permits separators such asb'\xff'and'é'while rejecting length-onebytearrayandmemoryviewseparators. It also preserves the observable__len__callback and reads the first underlying character or byte when a subclass overrides its reported length.ASCII strings use the cached kind fast path. For a non-ASCII string subclass that reports length one despite having longer underlying content, checking whether all code points fit in Latin-1 scans the string; CPython caches its internal string width. Generic argument-binding diagnostics, lower-level bytes-per-separator conversion, output-buffer lifetime, and allocation limits are outside this change.
Validation
binasciiandpystrhexsource and reproduced high-byte/Latin-1 separators, out-of-range characters, buffer rejection, callback ordering and subclasses with overridden__len__.test_binasciicoverage.