Skip to content

Align itertools constructor binding and conversions #9632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 9 commits into from
Nov 7, 2026
Merged

Align itertools constructor binding and conversions #9632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b60a1d0
Align batched arguments and termination behavior
youknowdot Nov 3, 2026
aed9a43
Align islice index conversion order
youknowdot Nov 3, 2026
eea2a85
Validate combinator sizes in CPython order
youknowdot Nov 3, 2026
c740933
Distinguish omitted repeat count from None
youknowdot Nov 3, 2026
61d03e1
Bind itertools arguments before conversions
youknowdot Nov 3, 2026
a0f59c3
Match iterator count conversion diagnostics
youknowdot Nov 3, 2026
bf26e22
Match repeat count overflow conversion
youknowdot Nov 3, 2026
300b261
Reuse the shared optional argument binder for islice
youknowdot Nov 3, 2026
60e3d91
Restore typed positional itertools arguments after binder validation
youknowdot Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/vm/src/builtins/int.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,7 @@ fn try_int_radix(obj: &PyObject, base: u32, vm: &VirtualMachine) -> PyResult<Big
}

// Retrieve inner int value:
#[cfg(any(test, feature = "serde", feature = "jit"))]
pub(crate) fn get_value(obj: &PyObject) -> &BigInt {
obj.downcast_ref::<PyInt>().unwrap().as_bigint()
}
Expand Down
Loading
Loading