Skip to content

Return None from bisect insort #9630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
youknowdot wants to merge 2 commits into from
Closed

Return None from bisect insort #9630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
611849f
Return None from bisect insort
youknowdot Nov 3, 2026
2839517
Preserve insort argument lifetime under Clippy
youknowdot Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions crates/stdlib/src/bisect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ mod _bisect {
}

#[pyfunction]
#[expect(
clippy::redundant_clone,
reason = "keep the original arguments alive until the insert result is released"
)]
fn insort_left(BisectArgs { a, x, lo, hi, key }: BisectArgs, vm: &VirtualMachine) -> PyResult {
// The search runs on the key, the insert has to put back the item itself.
let needle = match key {
Expand All @@ -117,14 +121,20 @@ mod _bisect {
x: needle,
lo,
hi,
key,
key: key.clone(),
},
vm,
)?;
vm.call_method(&a, "insert", (index, x))
let result = vm.call_method(&a, "insert", (index, x.clone()))?;
drop(result);
Ok(vm.ctx.none())
}

#[pyfunction]
#[expect(
clippy::redundant_clone,
reason = "keep the original arguments alive until the insert result is released"
)]
fn insort_right(BisectArgs { a, x, lo, hi, key }: BisectArgs, vm: &VirtualMachine) -> PyResult {
// The search runs on the key, the insert has to put back the item itself.
let needle = match key {
Expand All @@ -137,10 +147,12 @@ mod _bisect {
x: needle,
lo,
hi,
key,
key: key.clone(),
},
vm,
)?;
vm.call_method(&a, "insert", (index, x))
let result = vm.call_method(&a, "insert", (index, x.clone()))?;
drop(result);
Ok(vm.ctx.none())
}
}
Loading