You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Treat only exact list objects as deferred text/tail fragments when restoring Element state. A list subclass remains the original text or tail object instead of being joined into a string. The separate _children list-subclass behavior and TreeBuilder fragment handling are unchanged.
Validation
Compared with CPython 3.15.0 element_setstate_from_attributes, which uses PyList_CheckExact for both fields. CPython 3.15 reproductions confirmed identity preservation for list subclasses and lazy joining for exact lists.
Only exact lists restored as text or tail are pending fragments, matching CPython. List subclasses remain the original objects.
Assisted-by: OpenAI Codex:model version not exposed
PyElement.__setstate__ now marks restored text and tail as pending fragment lists only when each value has the exact type list. List subclasses no longer meet this check.
Changes: Element state restoration
Layer / File(s)
Summary
Pending-join flag classification crates/stdlib/src/elementtree.rs
__setstate__ now checks the exact types of text and tail when setting their pending-join flags. List subclasses are no longer classified as pending.
RustPython/RustPython#9591: Changes the input contract and validation for PyElement.__setstate__, which is also modified by this PR.
Suggested reviewers:youknowone
Merge Risk: Low · up to 0a561
The change preserves list-subclass objects as intended. It is mergeable with follow-up to confirm regression coverage for restored text and tail identity.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Preserve Element state list subclasses" matches the main change in the changeset. PyElement.setstate now marks restored text and tail as pending fragment lists only when their exact typ…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Preserve Element state list subclasses" matches the main change in the changeset. PyElement.setstate now marks restored text and tail as pending fragment lists only when their exact type is list. List subclasses keep their original objects, which the title describes. The title names the specific behavior change and does not cover the file-level details, which is acceptable.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
crates/stdlib/src/elementtree.rs-928-928: 1
928-928: Minor · Potential issue · Low value
Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.
Test gap: no tests were added for the new exact-list classification, so an implementation that still joins a list subclass restored as text could pass the existing ElementTree tests.
The regression could go undetected even though reading element.text would replace the original subclass object with a joined string.
This can occur when: A regression changes the text check back to a subclass-inclusive check, and a caller restores a list subclass through Element.__setstate__.
Reviewing files that changed from the base of the PR and between 18fc82b and 0a561b7.
Files selected for processing: 1
crates/stdlib/src/elementtree.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
Treat only exact list objects as deferred text/tail fragments when restoring Element state. A list subclass remains the original text or tail object instead of being joined into a string. The separate
_childrenlist-subclass behavior and TreeBuilder fragment handling are unchanged.Validation
element_setstate_from_attributes, which usesPyList_CheckExactfor both fields. CPython 3.15 reproductions confirmed identity preservation for list subclasses and lazy joining for exact lists.Summary by CodeRabbit
textandtailvalues are now handled as pending fragments only when they are plain lists; list subclasses retain their existing behavior.