Skip to content

Share borrowed str and bytes checks - #9625

Merged
youknowone merged 2 commits into
RustPython:mainfrom
youknowdot:fix/element-iter-bytes-wildcard-20261103
Nov 4, 2026
Merged

youknowone merged 2 commits into
RustPython:mainfrom
youknowdot:fix/element-iter-bytes-wildcard-20261103

Conversation

@youknowdot

@youknowdot youknowdot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Recognize b'*' as the all-elements wildcard in Element.iter, including bytes subclasses without calling an overridden equality method.
  • Add ArgBytesOrStr for owned str/bytes arguments, with with_ref borrowing their byte payload and with_object_ref probing a borrowed object without allocation or Python conversion. Strings retain their raw WTF-8 representation; other buffer exporters are not accepted.
  • Share the checks in ElementTree iteration, path detection, parser reads and event names, struct format matching, and bytes/bytearray hex separators. Event names no longer need a temporary byte vector. Original event objects and the hex separator's __len__ callback are preserved.

Validation

  • cargo check --locked --offline -p rustpython-vm -p rustpython-stdlib --tests passed.
  • cargo clippy --locked --offline -p rustpython-vm -p rustpython-stdlib --tests passed with the existing arc_with_non_send_sync warning at crates/vm/src/stdlib/_ctypes/base.rs:2246. A strict -D warnings run stops on that unchanged code.
  • Two new Rust unit tests cover object identity, direct payload borrowing, owned lifetime, WTF-8, and rejection without calling the probe closure. They were compiled but not executed locally.
  • Independent source review, normal commit hooks, and git diff --check passed.
  • The original bytes wildcard behavior was compared with CPython 3.15.0. RustPython runtime tests and the full workspace/C-API suites were not run locally; hosted CI is still required.

AI assistance

Implementation and source review were assisted by OpenAI Codex.

Treat b"*" like the string wildcard, including bytes subclasses, without invoking equality overrides.

Assisted-by: OpenAI Codex:model version not exposed
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Add ArgBytesOrStr and reuse zero-copy payload checks in ElementTree, struct format matching, and hex separator validation. Keep original Python objects and explicit callback ordering.

Assisted-by: OpenAI Codex:model version not exposed
@youknowdot youknowdot changed the title Recognize bytes wildcard in Element.iter Share borrowed str and bytes checks Nov 4, 2026
@codspeed

codspeed Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:fix/element-iter-bytes-wildcard-20261103 (6487fc8) with main (c992a81)2

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (f942d52) during the generation of this report, so c992a81 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I still suspect with_object_ref is the best idea rather than using ArgBytesOrStr directly there. but looks better

@youknowone
youknowone marked this pull request as ready for review November 4, 2026 22:24
@youknowone
youknowone merged commit 3c6b12b into RustPython:main Nov 4, 2026
21 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-04T22:24:38.060449Z
We couldn’t complete this review. Comment @codex review to try again.
6487fc8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants