Repository navigation
Drop replaced tracing callbacks outside locks - #9612
Merged
youknowone merged 2 commits intoNov 6, 2026
Merged
youknowone merged 2 commits into
youknowone merged 2 commits into
Conversation
Retain old trace and profile callbacks until all thread slots and VM state are updated and locks are released. Reserve all-thread storage before mutation so allocation failure leaves state unchanged. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Assisted-by: dot:frontier-intelligence
youknowone
approved these changes
Nov 6, 2026
youknowone
marked this pull request as ready for review
November 6, 2026 12:10
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retain replaced trace and profile callbacks until the current-thread or all-thread updates are complete and the associated locks and VM borrows are released. A callback's finalizer can reenter these APIs; dropping a last reference while holding a callback or thread-registry mutex can otherwise deadlock.
For all-thread setters, reserve storage for the old slot callbacks before changing global or slot state. On allocation failure, release the registry lock before constructing
MemoryErrorand leave tracing state unchanged. The lock order follows the existing thread-slot initialization path.Validation
prek run --files crates/vm/src/stdlib/sys.rs, normal commit hooks, andgit diff --checkpassed.test_threadingcases cover normal all-thread trace/profile updates, but no existing test identified directly covers finalizer reentry.Scope
This is a narrow callback-lifetime fix. Existing all-thread dispatch and stop-the-world differences from CPython remain outside this change. No Lib or test files were modified.