You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Align REG_MULTI_SZ input encoding with CPython - #9604
Align the REG_MULTI_SZ input conversion with CPython 3.15:
Preserve embedded and trailing NUL code units in list items rather than rejecting them.
Encode None as the same two-byte empty multi-string used by CPython and by an empty list.
Validate all list items before growing the output buffer, then encode into one growable byte buffer without per-item wide-string temporaries.
Existing error types/messages for invalid items and very large-value overflow behavior are not addressed; this does not claim complete winreg parity.
Validation
Independently source-reviewed against CPython v3.15.0 PC/winreg.c; a CPython-only PyUnicode_AsWideChar probe confirmed copying of embedded/trailing NULs.
prek hooks and git diff --check passed.
No RustPython compilation or Windows execution was run locally; CI is needed.
Summary by CodeRabbit
Bug Fixes
Registry multi-string values now encode None and empty lists with a single UTF-16 NUL terminator; previously, empty lists used two.
Lists are checked to ensure every item is a string before encoding.
Strings containing embedded NUL characters are now permitted in registry multi-string values.
Each string item is encoded as UTF-16LE and terminated with a NUL character.
Preserve embedded NULs, encode None as the empty multi-string, and validate all items before building one output buffer.
Assisted-by: dot:frontier-intelligence
No actionable comments were generated in the recent review.
Walkthrough
The REG_MULTI_SZ conversion changes how it encodes None and string lists. It validates that list items are strings, adds UTF-16 NUL terminators, and permits interior NULs in strings.
None encodes as one UTF-16 NUL. List items are type-checked before encoding. Each string gets a terminator, followed by a final terminator. An empty list encodes as one NUL. Strings with interior NULs are no longer rejected.
RustPython issue 6839: The issue concerns standard-library updates against the CPython 3.15 baseline. This change updates winregREG_MULTI_SZ input conversion to match that baseline.
Suggested reviewers:youknowone
Merge Risk: Minimal · up to 98a6c
The encoding change has no identified merge-blocking defect. Merge after normal Windows build and test checks pass.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: aligning REG_MULTI_SZ input encoding with CPython.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 729c8a3 and 98a6c86.
Files selected for processing: 1
crates/vm/src/stdlib/winreg.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
The REG_MULTI_SZ encoding update removed the final to_wide_cstring call. Remove its obsolete trait import to fix Windows Clippy.
Assisted-by: dot:frontier-intelligence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the
REG_MULTI_SZinput conversion with CPython 3.15:Noneas the same two-byte empty multi-string used by CPython and by an empty list.Existing error types/messages for invalid items and very large-value overflow behavior are not addressed; this does not claim complete winreg parity.
Validation
PC/winreg.c; a CPython-onlyPyUnicode_AsWideCharprobe confirmed copying of embedded/trailing NULs.prekhooks andgit diff --checkpassed.Summary by CodeRabbit
Noneand empty lists with a single UTF-16 NUL terminator; previously, empty lists used two.