Repository navigation
Preserve surrogates in winreg QueryValue results - #9602
Merged
youknowone merged 1 commit intoNov 4, 2026
Merged
youknowone merged 1 commit into
youknowone merged 1 commit into
Conversation
Decode returned UTF-16 through WTF-8 for the Python API while retaining the existing public String host API. Assisted-by: dot:frontier-intelligence
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
youknowone
approved these changes
Nov 3, 2026
youknowone
marked this pull request as ready for review
November 3, 2026 19:03
youknowone
enabled auto-merge (squash)
November 3, 2026 19:03
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve unpaired UTF-16 surrogate code units in the string returned by
winreg.QueryValue, matching CPython'sPyUnicode_FromWideCharbehavior. A new WTF-8 host path produces the Python string directly; the existing public Rustquery_default_valuesignature and strict String-decoding behavior are retained through a shared monomorphized decoder.The first-NUL rule, missing-value result, registry errors, and child-key close path remain as before. This patch does not change QueryValue argument parsing or claim complete registry parity.
This touches the same regions as #9593 and #9599. A local composition required conflict resolution to retain #9593's input conversion/audit and #9599's wide-unit alignment handling; that resolved source was independently reviewed, but has not been built or run.
Validation
PC/winreg.cand RustPython'sWtf8Buf::from_wide.prekhooks andgit diff --checkpassed.