Skip to content

Match CPython HKEY argument conversion #9586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Nov 4, 2026
Merged

Match CPython HKEY argument conversion #9586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions crates/vm/src/stdlib/winreg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,29 @@ mod winreg {
if let Some(hkey_obj) = obj.downcast_ref::<PyHkey>() {
return Ok(Self(hkey_obj.hkey.load()));
}
// Then try int
let handle = usize::try_from_object(vm, obj)?;
if vm.is_none(&obj) {
return Err(vm.new_type_error("None is not a valid HKEY in this context"));
}
let Some(value) = obj.downcast_ref::<PyInt>() else {
return Err(vm.new_type_error("The object is not a PyHKEY object"));
};
let value = value.as_bigint();
let negative = value.sign() == Sign::Minus;
let handle = if negative {
value.to_isize().map(|v| v as usize)
} else {
value.to_usize()
}
.ok_or_else(|| {
let message = if cfg!(target_pointer_width = "64") {
"int too big to convert"
} else if negative {
"Python int too large to convert to C long"
} else {
"Python int too large to convert to C unsigned long"
};
vm.new_overflow_error(message)
})?;
Ok(Self(handle as host_winreg::HKEY))
}
}
Expand Down
Loading