Repository navigation
Match CPython HKEY argument conversion - #9586
Merged
youknowone merged 1 commit intoNov 4, 2026
Merged
Conversation
Accept signed and unsigned pointer-width integer handles, reject index-only objects, and report the same None and overflow errors as CPython. Preserve the existing PyHKEY handle path. Assisted-by: dot:frontier-intelligence
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 3, 2026
youknowone
approved these changes
Nov 3, 2026
youknowone
marked this pull request as ready for review
November 4, 2026 10:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clinic_HKEY_converterfor the existingHKEYArgusers:DeleteTree,QueryInfoKey,QueryValue, andQueryValueEx.Noneand non-integer__index__objects with CPython's errors.This only changes the shared converter's current callers. Other winreg functions that still require
PyHkeyare outside this patch; it does not assert complete winreg parity. The converter hunk is separate from #9573's signature changes in the same file.Validation
PC/winreg.c,PC/clinic/winreg.c.h, andObjects/longobject.c, including Windows 32-bit and 64-bit conversion bounds and errors.prekhooks andgit diff --checkpassed.