Repository navigation
Align LZMA compressor and filter validation - #9582
Merged
youknowone merged 3 commits intoNov 4, 2026
Merged
Conversation
Use CPython exception types for incompatible compressor options and validate filter properties with the keyword parser ordering, including mutation during index conversion. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Assisted-by: OpenAI Codex:model version not exposed
Apply update_lib.cmd_auto_mark.apply_test_changes to the two repeated unexpected successes observed in the exact-head Ubuntu CI run. Preserve all test bodies and assertions. Assisted-by: OpenAI Codex:model version unavailable
Contributor
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [x] lib: cpython/Lib/lzma.py dependencies:
dependent tests: (118 tests)
Legend:
|
youknowone
approved these changes
Nov 4, 2026
youknowone
marked this pull request as ready for review
November 4, 2026 22:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 similar comment
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorfor incompatible compressor integrity checks and simultaneous preset/filter arguments, as CPython does._encode_filter_propertiesfilter option names, numeric fields and preset before encoding. Preserve the argument parser's count check, conversion order and subsequent unknown-key rejection.flushlifecycle unchanged. This is independent of the engine-port work in common: port the lzma engine to xz-core #8639, whose stdlib changes address the filter-chain length limit.Validation
Modules/_lzmamodule.c.prek run --files crates/stdlib/src/lzma.rs,git diff --check, and normal commit hooks passed.test_lzmaexpected-failure markers remain pending exact runtime evidence; a newly passing marked case may appear as an unexpected success.Scope
This does not claim complete LZMA compatibility: existing dict-like mapping support, some error ordering and backend validation/error mapping remain separate. In particular, this does not alter the backend finish loop. The local
xzAPI documents repeatingFinishuntilStreamEnd; whether an existing single-threaded path can return early with spare output is not established here.