You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
_winapi.WaitForSingleObject currently maps every negative timeout to INFINITE. CPython 3.15 parses the argument as a Windows unsigned-long bitfield: for example, -2 becomes 0xfffffffe rather than 0xffffffff, so the current behavior can wait indefinitely instead of using the requested timeout.
Accept indexable integers of arbitrary size and use their low 32 bits.
Match CPython's integer value out of range DeprecationWarning outside [-231, 232-1], propagating it when warnings are errors before starting the wait.
Preserve handle-first conversion and reject non-indexable values without invoking the wait.
This follows the CPython 3.15 Clinic wrapper, k argument conversion, and PyLong_AsNativeBytes. For an unusually long type name where a multibyte character crosses CPython's 50-byte diagnostic cutoff, RustPython preserves a valid UTF-8 boundary and may differ in the diagnostic. This change overlaps #9572; integration must preserve that PR's parameter names as well as this conversion.
Validation
Independent source review checked the integer range boundaries, low-bit masking, error and warning order, and warning-as-error path against CPython's code.
rustfmt --edition 2024 --check, git diff --check, and the normal commit hook passed.
Windows runtime, RustPython workspace/C API, and target tests were not run locally: the coordinated native execution guard and lock are absent and the offline dependency cache is incomplete. Hosted CI is pending. In particular, no live wait behavior or warning filter result is claimed as tested.
AI assistance
Implementation and source review were assisted by dot. The runtime does not expose its exact model version.
Summary by CodeRabbit
Bug Fixes
Windows wait timeouts now accept integer-like values. Values that cannot be interpreted as integers raise a TypeError, while errors raised during integer conversion are preserved.
Timeouts outside the supported range trigger a deprecation warning and are converted using unsigned 32-bit wrapping. Negative values no longer automatically mean an infinite timeout.
Use CPython 3.15 unsigned-long bitfield conversion, including its out-of-range deprecation warning, instead of treating every negative timeout as infinite.
Assisted-by: dot:frontier-intelligence
No actionable comments were generated in the recent review.
Walkthrough
WaitForSingleObject now accepts a Python object for its timeout. It converts the value through the index protocol, warns for values outside the inclusive i32::MIN..=u32::MAX range, and applies unsigned 32-bit masking.
Changes: Windows API timeout conversion
Layer / File(s)
Summary
Timeout conversion and validation crates/vm/src/stdlib/_winapi.rs
WaitForSingleObject now raises TypeError for values that do not support index conversion and propagates conversion errors. It warns when the value is outside the specified range, then applies unsigned 32-bit masking. Negative values no longer map to infinite timeout, and values above u32::MAX are no longer rejected with OverflowError.
No actionable merge-blocking issue is established for the timeout conversion change. Merge readiness remains subject to normal Windows CI checks.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Mask Windows single-wait timeouts" matches the main change. The PR changes _winapi.WaitForSingleObject so its timeout uses unsigned 32-bit masking, replacing the old behavior that mapped …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Mask Windows single-wait timeouts" matches the main change. The PR changes _winapi.WaitForSingleObject so its timeout uses unsigned 32-bit masking, replacing the old behavior that mapped negative values to infinite and raised OverflowError above u32::MAX. The title is short and specific. It does not name the deprecation warning, but it does not need to cover every detail.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 18fc82b and 9160d2f.
Files selected for processing: 1
crates/vm/src/stdlib/_winapi.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_winapi.WaitForSingleObjectcurrently maps every negative timeout toINFINITE. CPython 3.15 parses the argument as a Windows unsigned-long bitfield: for example, -2 becomes 0xfffffffe rather than 0xffffffff, so the current behavior can wait indefinitely instead of using the requested timeout.integer value out of rangeDeprecationWarning outside [-231, 232-1], propagating it when warnings are errors before starting the wait.This follows the CPython 3.15 Clinic wrapper,
kargument conversion, andPyLong_AsNativeBytes. For an unusually long type name where a multibyte character crosses CPython's 50-byte diagnostic cutoff, RustPython preserves a valid UTF-8 boundary and may differ in the diagnostic. This change overlaps #9572; integration must preserve that PR's parameter names as well as this conversion.Validation
rustfmt --edition 2024 --check,git diff --check, and the normal commit hook passed.AI assistance
Implementation and source review were assisted by dot. The runtime does not expose its exact model version.
Summary by CodeRabbit
TypeError, while errors raised during integer conversion are preserved.