Repository navigation
Align positional OS and import signatures - #9568
Merged
youknowone merged 1 commit intoNov 3, 2026
Merged
Conversation
Use the CPython parameter names for nt.kill, nt.waitpid, and _imp.exec_dynamic, and reject keyword arguments for nt._path_isdir. Assisted-by: dot:frontier-intelligence
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
youknowone
approved these changes
Nov 3, 2026
youknowone
marked this pull request as ready for review
November 3, 2026 16:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align four positional-only callable signatures with CPython 3.15:
path=for Windowsnt._path_isdir, matching itsMETH_OClinic wrapper. Its existing path conversion and predicate logic are otherwise unchanged.signalandoptionsfor Windowsnt.killandnt.waitpid, andmodfor_imp.exec_dynamic.The existing
_path_isdirpath-conversion error handling does not yet match CPython in all cases; this change does not claim full behavior parity. The names and kinds were checked against CPython v3.15.0's posix Clinic output and import Clinic output. These entries appear in whats_left CI output.Validation
rustfmt --edition 2024 --check,git diff --check, and the normal commit hook passed.AI assistance
Implementation and source review were assisted by dot. The runtime does not expose its exact model version.