Skip to content

Align Windows overlapped signatures - #9566

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/windows-overlapped-signatures-20261103
Nov 3, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/windows-overlapped-signatures-20261103

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

  • Match 14 Windows _overlapped function and method parameter names to CPython 3.15 Clinic signatures.
  • Expose native False/0 defaults for Overlapped.getresult, WSARecv, and WSARecvFrom. The omitted values remain Rust bool/u32; there is no Python default-object allocation or conversion.
  • Leave WSARecvFromInto and the existing Rust test untouched in this change.

The 17 targeted entries were present in the Windows whats_left report. Signatures and calling conventions were checked against CPython v3.15.0 Clinic output.

Validation

  • Independent source review checked all target names, positional-only binding, arity and conversion order, direct scalar defaults, and unchanged Windows operations. This is source review, not an execution claim.
  • rustfmt --edition 2024 --check and git diff --check passed; the normal commit hook passed all applicable checks, including rustfmt and cspell.
  • Local compilation, workspace/C API tests and RustPython runtime checks were not run: the coordinated native execution guard and lock are absent, and the offline dependency cache is incomplete. Windows CI is required for target compilation and execution; no hosted pass is claimed.

AI assistance

Implementation and source review were assisted by dot. The runtime does not expose its exact model version.

Match CPython parameter names and expose native bool and integer defaults without boxing or changing positional argument conversion.

Assisted-by: dot:frontier-intelligence
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@youknowone
youknowone marked this pull request as ready for review November 3, 2026 16:39
@youknowone
youknowone enabled auto-merge (squash) November 3, 2026 16:40
@youknowone
youknowone disabled auto-merge November 3, 2026 16:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T16:44:13.789160Z eb2be87 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@youknowone
youknowone merged commit 849e046 into RustPython:main Nov 3, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants