You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Declare five nullable datetime defaults with Option<PyObjectRef> and default = None: time/datetime constructor tzinfo, and now, fromtimestamp, astimezonetz.
Omission remains a native absent state. The three methods still create a None reference lazily at the same body fallback. Timezone validation, callback order and pickle-slot branches stay in their existing locations. Rendered signatures are unchanged; typed None metadata replaces Raw metadata.
The earlier three string-default changes have been restored. Both timespec arguments and the datetime separator keep their Missing paths, which avoid default-object construction, string copying and separator validation work on omission. The other 25 sentinel/display overrides also remain unchanged.
Independent exact-head source review, normal pre-commit hooks, rustfmt and diff checks passed for 1d5d31e42de8cefecb182d4f00d78a0e20e49cbf.
No test assertions, test files or Lib files changed.
Workspace/C-API tests and Clippy, plus canonical test_datetime, were attempted offline on this head. All stopped before compilation because the pinned parking_lot_core git dependency is unavailable locally. No local native test pass is claimed.
CI for this head is pending. Actual canonical test_datetime outcomes on the three operating systems remain to be checked.
AI-assisted implementation and review with OpenAI Codex; model version not exposed.
Summary by CodeRabbit
Bug Fixes
Time and date functions now consistently treat an omitted timezone argument as None, while retaining existing timezone handling when a value is provided.
Use Option None for five timezone arguments, typed auto defaults for two timespec arguments, and a raw Python T default for the datetime separator. Preserve supplied separator validation in the method body, timezone checks, pickle constructors, and every unchanged/timedelta omission sentinel.
Source-reviewed against CPython 3.15.0 d220409a13b77de7a6c30abe16ea90db01528edc. No test expectations or Lib files changed. Local native validation remains limited by the available dependency closure.
Assisted-by: OpenAI Codex:model version not exposed
No actionable comments were generated in the recent review.
Walkthrough
Timezone parameters in datetime constructors and methods now use Option<PyObjectRef> with None as the default. Consumers pass Python None when the option is absent.
Changes: Datetime timezone arguments
Layer / File(s)
Summary
Time and datetime constructors crates/stdlib/src/_datetime.rs
TimeArgs and DateTimeArgs use optional timezone values. Their constructors pass the values through timezone conversion.
Datetime methods crates/stdlib/src/_datetime.rs
now, fromtimestamp, and astimezone use optional timezone values and substitute Python None when absent.
The changes preserve timezone argument behavior and public signatures. No actionable merge-blocking issue was identified; normal build and test checks should complete before merging.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: declaring nullable datetime defaults directly.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 5 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
ast-grep (0.51.1)
ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/cpp/security/libxml2-audit-parser-cpp.yml
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 0a88bee and 1d5d31e.
Files selected for processing: 1
crates/stdlib/src/_datetime.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.
Restore runtime defaults whose concrete literal lowering adds Python object creation, conversion, or reference management on omitted arguments. Keep only cost-preserving None default cleanup, where applicable. No test code or expectations changed.
Assisted-by: OpenAI Codex:model version not exposed
youknowdot
changed the title
Declare concrete datetime argument defaults directly
Declare nullable datetime defaults directly
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
youknowdot
changed the title
Summary
Declare five nullable datetime defaults with
Option<PyObjectRef>anddefault = None:time/datetimeconstructortzinfo, andnow,fromtimestamp,astimezonetz.Omission remains a native absent state. The three methods still create a None reference lazily at the same body fallback. Timezone validation, callback order and pickle-slot branches stay in their existing locations. Rendered signatures are unchanged; typed None metadata replaces Raw metadata.
The earlier three string-default changes have been restored. Both
timespecarguments and the datetime separator keep their Missing paths, which avoid default-object construction, string copying and separator validation work on omission. The other 25 sentinel/display overrides also remain unchanged.Reviewed against CPython 3.15.0 d220409a13b77de7a6c30abe16ea90db01528edc datetime source. This PR is independent of the other default-cleanup PRs.
Validation
1d5d31e42de8cefecb182d4f00d78a0e20e49cbf.test_datetime, were attempted offline on this head. All stopped before compilation because the pinnedparking_lot_coregit dependency is unavailable locally. No local native test pass is claimed.test_datetimeoutcomes on the three operating systems remain to be checked.AI-assisted implementation and review with OpenAI Codex; model version not exposed.
Summary by CodeRabbit
None, while retaining existing timezone handling when a value is provided.