Skip to content

Remove redundant concrete signature default overrides #9558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Nov 3, 2026
Merged

Remove redundant concrete signature default overrides #9558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions crates/stdlib/src/binascii.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ mod decl {
data: ArgAsciiBuffer,
#[pyarg(named, optional)]
strict_mode: OptionalArg<ArgIntoBool>,
#[pyarg(named, default = ArgIntoBool::TRUE, py_default = "True")]
#[pyarg(named, default = ArgIntoBool::TRUE)]
padded: ArgIntoBool,
#[pyarg(named, optional, py_default = "BASE64_ALPHABET")]
alphabet: OptionalArg<PyBytesRef>,
Expand Down Expand Up @@ -322,11 +322,11 @@ mod decl {
struct B2aBase64Args {
#[pyarg(positional)]
data: ArgBytesLike,
#[pyarg(named, default = ArgIntoBool::TRUE, py_default = "True")]
#[pyarg(named, default = ArgIntoBool::TRUE)]
padded: ArgIntoBool,
#[pyarg(named, default = 0)]
wrapcol: usize,
#[pyarg(named, default = ArgIntoBool::TRUE, py_default = "True")]
#[pyarg(named, default = ArgIntoBool::TRUE)]
newline: ArgIntoBool,
#[pyarg(named, optional, py_default = "BASE64_ALPHABET")]
alphabet: OptionalArg<ArgBytesLike>,
Expand Down Expand Up @@ -413,7 +413,7 @@ mod decl {
struct B2aBase32Args {
#[pyarg(positional)]
data: ArgBytesLike,
#[pyarg(named, default = ArgIntoBool::TRUE, py_default = "True")]
#[pyarg(named, default = ArgIntoBool::TRUE)]
padded: ArgIntoBool,
#[pyarg(named, default = 0)]
wrapcol: usize,
Expand All @@ -425,7 +425,7 @@ mod decl {
struct A2bBase32Args {
#[pyarg(positional)]
data: ArgAsciiBuffer,
#[pyarg(named, default = ArgIntoBool::TRUE, py_default = "True")]
#[pyarg(named, default = ArgIntoBool::TRUE)]
padded: ArgIntoBool,
#[pyarg(named, optional, py_default = "BASE32_ALPHABET")]
alphabet: OptionalArg<PyBytesRef>,
Expand Down Expand Up @@ -489,7 +489,7 @@ mod decl {
struct B2aBase85Args {
#[pyarg(positional)]
data: ArgBytesLike,
#[pyarg(named, default = ArgIntoBool::FALSE, py_default = "False")]
#[pyarg(named, default = ArgIntoBool::FALSE)]
pad: ArgIntoBool,
#[pyarg(named, default = 0)]
wrapcol: usize,
Expand Down Expand Up @@ -569,23 +569,23 @@ mod decl {
struct B2aAscii85Args {
#[pyarg(positional)]
data: ArgBytesLike,
#[pyarg(named, default = ArgIntoBool::FALSE, py_default = "False")]
#[pyarg(named, default = ArgIntoBool::FALSE)]
foldspaces: ArgIntoBool,
#[pyarg(named, default = 0)]
wrapcol: usize,
#[pyarg(named, default = ArgIntoBool::FALSE, py_default = "False")]
#[pyarg(named, default = ArgIntoBool::FALSE)]
pad: ArgIntoBool,
#[pyarg(named, default = ArgIntoBool::FALSE, py_default = "False")]
#[pyarg(named, default = ArgIntoBool::FALSE)]
adobe: ArgIntoBool,
}

#[derive(FromArgs)]
struct A2bAscii85Args {
#[pyarg(positional)]
data: ArgAsciiBuffer,
#[pyarg(named, default = ArgIntoBool::FALSE, py_default = "False")]
#[pyarg(named, default = ArgIntoBool::FALSE)]
foldspaces: ArgIntoBool,
#[pyarg(named, default = ArgIntoBool::FALSE, py_default = "False")]
#[pyarg(named, default = ArgIntoBool::FALSE)]
adobe: ArgIntoBool,
#[pyarg(named, optional, py_default = "b''")]
ignorechars: OptionalArg<ArgBytesLike>,
Expand Down
4 changes: 2 additions & 2 deletions crates/vm/src/stdlib/os.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2192,9 +2192,9 @@ pub(super) mod _os {
dst: crt_fd::Borrowed<'fd>,
#[pyarg(any)]
count: i64,
#[pyarg(any, default, py_default = "None")]
#[pyarg(any, default = None)]
offset_src: Option<crt_fd::Offset>,
#[pyarg(any, default, py_default = "None")]
#[pyarg(any, default = None)]
offset_dst: Option<crt_fd::Offset>,
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/posix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,7 +1414,7 @@ pub mod module {
path: OsPathOrFd<'fd>,
#[pyarg(any)]
mode: u32,
#[pyarg(named, default, py_default = "None")]
#[pyarg(named, default = None)]
dir_fd: Option<ChmodDirFd>,
// CPython writes the platform expression; on posix it is always true.
#[pyarg(named, default = true, py_default = "(os.name != 'nt')")]
Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/posix_compat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub(crate) mod module {
path: PyObjectRef,
#[pyarg(any)]
mode: PyObjectRef,
#[pyarg(named, default, py_default = "None")]
#[pyarg(named, default = None)]
dir_fd: Option<PyObjectRef>,
#[pyarg(named, optional, py_default = "(os.name != 'nt')")]
follow_symlinks: OptionalArg<PyObjectRef>,
Expand Down
Loading