You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normal pre-commit hooks, rustfmt, and diff checks passed; worktree clean.
Exact-head workspace and C-API tests/Clippy, plus canonical test_binascii and test_os, were attempted offline. All stopped before compilation because the pinned parking_lot_core git dependency is unavailable locally. No runtime tests have passed locally; CI remains pending.
No Lib files, snippets, test expectations, or global argument-order behavior changed.
AI-assisted implementation and review with OpenAI Codex; model version not exposed.
Summary by CodeRabbit
Refactor
Updated how optional arguments are declared across encoding and file-system operations. Their available options and runtime behavior remain unchanged, so no user-facing changes are expected.
Reuse ArgIntoBool::py_default for eleven constant booleans, and declare four existing Option None defaults directly. Runtime field types, argument conversion, function bodies, and rendered Python defaults are unchanged. Preserve semantic and symbolic overrides.
Source-reviewed against CPython 3.15.0 d220409a13b77de7a6c30abe16ea90db01528edc. No test assertions or Lib files changed. Native validation remains subject to the available dependency closure.
Assisted-by: OpenAI Codex:model version not exposed
No actionable comments were generated in the recent review.
Walkthrough
The changes remove explicit Python-literal defaults from argument declarations in binascii, os, and POSIX modules. The stated native defaults, argument types, and implementations remain unchanged.
RustPython/RustPython#9536: Updates the same CopyFileRangeArgs and ChmodArgs declarations; this PR continues that signature work.
RustPython/RustPython#9561: Also preserves native argument defaults, and extends the approach to PySsize and compression arguments.
Suggested reviewers:youknowone
Merge Risk: Minimal · up to ae0c7
The annotation cleanup preserves argument behavior and displayed defaults. No actionable merge-blocking issue was identified; normal CI validation remains pending.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: removing redundant concrete signature default overrides.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 4 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
ast-grep (0.51.1)
ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/python/security/http-response-from-request.yml
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 7ac18a1 and ae0c720.
Files selected for processing: 4
crates/stdlib/src/binascii.rs
crates/vm/src/stdlib/os.rs
crates/vm/src/stdlib/posix.rs
crates/vm/src/stdlib/posix_compat.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove 15 redundant
py_defaultannotations without changing argument types, function bodies, assertions, or rendered Python signatures.ArgIntoBool::py_default()for 11 existing constant boolean defaults in binascii.Option<T>None defaults directly: bothcopy_file_rangeoffsets andchmod.dir_fdin posix and posix_compat.Rawto typedBool/None, which render the same text. This does not depend on Support Python None defaults in object argument declarations #9557.follow_symlinks.Source-reviewed against CPython 3.15.0 at d220409a13b77de7a6c30abe16ea90db01528edc: binascii defaults, chmod, and copy_file_range.
Validation
test_binasciiandtest_os, were attempted offline. All stopped before compilation because the pinnedparking_lot_coregit dependency is unavailable locally. No runtime tests have passed locally; CI remains pending.AI-assisted implementation and review with OpenAI Codex; model version not exposed.
Summary by CodeRabbit